Make sure each peer heartbeat has a timeout #2009
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also cleanup the heartbeat code, so each heartbeat request/response runs in a future with a single timeout.
teor2345
force-pushed
the
heartbeat-timeout
branch
from
44422fd to
c5332f8
Compare
2 tasks
teor2345
commented
Apr 14, 2021
teor2345
commented
Apr 14, 2021
dconnolly
approved these changes
Apr 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
It's hard to have consistent timeouts when we have to add a
timeout()to thePingand the completion channel during the heartbeat.If the peer is busy, we want to wait for it to be ready, rather than closing the connection immediately (#1551).
Solution
The code in this pull request has:
Review
@dconnolly reviewed #1850, which this code is based on.
This change blocks some of the upcoming security refactors, so it should be merged soon.
Related Issues
Closes #1551.
Follow Up Work
Wait on shutdowns as well as the heartbeat timeout (#1783, #1678)