Move the preallocate tests into their own files #1977

teor2345 · 2021-04-06T00:42:30Z

Motivation

In #1920, we put the preallocate tests in the same files as the TrustedPreallocate impls.

But in Zebra, we try to put tests in their own files.

Solution

move the preallocate tests into their own files
move the MetaAddr proptest into its own file
do some minor formatting and cleanups

Review

Anyone can review. This code movement isn't urgent.

@preston-evans98 you might also want to review this, but don't worry if you're busy.

Related Issues

Cleanup after #1920.

Follow Up Work

Turn the InventoryHash and MetaAddr tests into proptests.

And move the MetaAddr proptest into its own file. Also do some minor formatting and cleanups.

zebra-chain/src/sprout/tests/preallocate.rs

zebra-chain/src/transaction/tests/preallocate.rs

zebra-network/src/meta_addr/tests/preallocate.rs

zebra-network/src/protocol/external/tests/preallocate.rs

zebra-chain/src/block/tests/preallocate.rs

Co-authored-by: Deirdre Connolly <[email protected]>

zebra-chain/src/block/tests/preallocate.rs

teor2345 · 2021-04-07T02:32:39Z

This is blocking security fixes, so I merged it.

zebra-network/src/meta_addr/tests/prop.rs

Move the preallocate tests into their own files

77a5ab2

And move the MetaAddr proptest into its own file. Also do some minor formatting and cleanups.

teor2345 added A-rust Area: Updates to Rust code C-cleanup Category: This is a cleanup P-Low labels Apr 6, 2021

teor2345 requested a review from a team April 6, 2021 00:42

teor2345 self-assigned this Apr 6, 2021

teor2345 added this to the 2021 Sprint 7 milestone Apr 6, 2021