Port zebra-chain::sapling to zebra-chain::orchard
#1885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dconnolly
added
E-med
A-rust
Closed
53 tasks
|
@dconnolly let me know when you want a review on this PR. |
I've moved it to 'ready for review', while I add more tests and clean up this first pass. I figure that a first pass can get merged imminently, with the understanding that changes from the spec, keeping an eye on progress on the |
teor2345
suggested changes
Mar 18, 2021
teor2345
reviewed
Mar 23, 2021
teor2345
reviewed
Mar 23, 2021
4 tasks
teor2345
reviewed
Mar 29, 2021
teor2345
reviewed
Mar 29, 2021
teor2345
reviewed
Mar 29, 2021
teor2345
reviewed
Mar 29, 2021
teor2345
reviewed
Mar 29, 2021
teor2345
reviewed
Mar 29, 2021
teor2345
reviewed
Mar 29, 2021
teor2345
reviewed
Mar 29, 2021
teor2345
reviewed
Mar 29, 2021
daira
reviewed
Apr 5, 2021
daira
reviewed
Apr 5, 2021
…e it If we need Hash, we may need to replace the inner type with bytes.
But I added a max 10-bit value check in S() on j.
…s of those Also modify the string encoding/decoding rountrip proptest to be just an exerciser of the keygen for now.
dconnolly
force-pushed
the
orchard-chain
branch
from
42f7bb5 to
7bcf779
Compare
teor2345
approved these changes
Apr 30, 2021
There was a problem hiding this comment.
Looks good to me, but I'm going to leave it to @dconnolly to merge.
dconnolly
added a commit
that referenced
this pull request
Apr 30, 2021
…parts NU5 proposes Unified Addresses, which would supplant any classic standalone pool address for Orchard. #1885 (comment)
2 tasks
This was referenced Dec 16, 2021
Closed
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We need a bunch of data structures and implementations for Orchard, that share a lot of similarities for the things that we've already implemented for Sapling, modulo Sinsemilla hashes, Actions, and using Pallas instead of Jubjub.
Solution
Port our
zebra_chain::saplingcode tozebra_chain::orchard, adding/updating/removing where appropriate.The code in this pull request has:
Review
@teor2345 @oxarbitrage
Related Issues
This resolve a lot of tickets that should be linked from NU5 spec tracking, please create and fill them in here.
#1856
Closes #1864 ?
Follow Up Work
redpallasinprimitivesfor now. There is a proposal to makeredjubjubgeneric over traits to make itreddsa. I haven't really formed an opinion yet on this, because it would be globally generic, but for Jubjub and Pallas to start. I personally would be fine with a port of RedJubjub to RedPallas, not generic, perhaps just internal to zebra-chain right now, at least to get things working. replaceredpallasmodule withreddsacrate #2080