Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: bump build and test timeouts to 60 minutes #1757

Merged
merged 1 commit into from
Feb 16, 2021
Merged

CI: bump build and test timeouts to 60 minutes #1757

merged 1 commit into from
Feb 16, 2021

Conversation

dconnolly
Copy link
Contributor

Motivation

We've started running the CI workflow on #main post-merge again. Several job steps are running into timeouts on #main. We're also fiddling with the cargo env vars to avoid running out of space on the GitHub runners.

Solution

To give some margins to trying all these tweaks, this change bumps the timeouts on the build and test jobs/steps to one hour.

Review

Anyone can review, but @oxarbitrage @teor2345 . Medium urgent as we have timeouts on CI runs on #main.

Related Issues

#1756

Follow Up Work

@dconnolly dconnolly added A-devops Area: Pipelines, CI/CD and Dockerfiles A-infrastructure Area: Infrastructure changes labels Feb 16, 2021
@dconnolly dconnolly added this to the 2021 Sprint 3 milestone Feb 16, 2021
@dconnolly dconnolly linked an issue Feb 16, 2021 that may be closed by this pull request
@dconnolly dconnolly requested a review from teor2345 February 16, 2021 16:00
@oxarbitrage
Copy link
Contributor

Hmm, i think the test builds will almost always need more time as they build everything and later run the tests. I will say 60 minutes there is fine. In the build only job we can go with 50 minutes and in the without features 45 mins ?

We can increase this values if needed but some difference between the timeouts could help us spot certain rare problems.

@dconnolly
Copy link
Contributor Author

Hmm, i think the test builds will almost always need more time as they build everything and later run the tests. I will say 60 minutes there is fine. In the build only job we can go with 50 minutes and in the without features 45 mins ?

We can increase this values if needed but some difference between the timeouts could help us spot certain rare problems.

Since we're experimenting with flags, and to have some more consistent expectations of how long jobs take, I rounded up to 60mins for now, but am amenable to changing them again later. I would rather the top margin be large with room to experiment rather than too low. The GitHub job max is like 6 hours or something.

@oxarbitrage
Copy link
Contributor

Ok, fair, approving.

@dconnolly dconnolly merged commit 9493391 into main Feb 16, 2021
@dconnolly dconnolly deleted the ci-timeouts branch February 16, 2021 17:47
@teor2345 teor2345 mentioned this pull request Feb 23, 2021
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-devops Area: Pipelines, CI/CD and Dockerfiles A-infrastructure Area: Infrastructure changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Increase CI workflow timeouts
2 participants