Split memory_state to avoid giant test module #1258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
blocked by #1257, which it is based upon |
|
I merged #1257, so I think this PR is unblocked. |
|
(I'll review after the conflicts have been resolved, because that makes |
1 task
yaahc
force-pushed
the
memory-state-split
branch
from
1d2a3b6 to
9161acc
Compare
This was referenced Nov 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Prior to this PR
memory_statedefined and implemented functionality for three different types,Chain,NonFinalizedState, andQueuedBlocks. Each of these components will need a fair number of unit tests, and I realized that as its currently organized it would be difficult to organize the tests or at a glance figure out which tests are testing which components.Solution
This PR changes the organization of
memory_statesuch that each component it exports is defined in its own module. In follow up PRs each module will get its own test module, which will focus exclusively on unit tests for the item defined there-in.The code in this pull request has:
Documentation CommentsUnit Tests and Property TestsReview
Related Issues
Follow Up Work
This PR doesn't implement any of the items mentioned in the above tracking issue, but it should make it easier to review the code that later does introduce said tests.