RFC: Contextual Difficulty #1246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a header, summary, and motivation
And update the state RFC definitions to match.
Outline the core calculations and checks.
teor2345
added
A-docs
|
@yaahc can you do a quick review to make sure that the definitions and guide-level explanation fit with the current state service design? In particular, the "relevant chain" for contextual validation needs to work with the non-finalised and finalised state. I'll also get others to have a look when they have some time. |
yaahc
reviewed
Nov 4, 2020
Co-authored-by: Jane Lusby <[email protected]>
Also split the difficulty adjustment and difficulty filter checks
yaahc
reviewed
Nov 5, 2020
Update the design based on the spec bugs in ZcashFoundation#1276, ZcashFoundation#1277, and zcash/zips#416. These changes make the difficulty filter into a context-free check, so we remove it from this contextual validation RFC.
Includes most of the implementation, modules for each function, and draft notes for some of the remaining parts of the RFC.
teor2345
force-pushed
the
contextual-difficulty-rfc
branch
from
39632e8 to
ebc0fc2
Compare
|
This design is now complete enough for an additional review. The guide-level and reference-level explanations contain a substantially complete first draft. |
And finish off the first draft of the RFC.
teor2345
commented
Nov 13, 2020
teor2345
commented
Nov 13, 2020
teor2345
commented
Nov 13, 2020
teor2345
commented
Nov 13, 2020
teor2345
commented
Nov 13, 2020
We have to clone the data to pass a fixed-length array to a function, so we might as well sort that array to find the median, and avoid a copy.
yaahc
previously approved these changes
Nov 19, 2020
And fix the median_timespan_bounded comment
yaahc
previously approved these changes
Nov 19, 2020
|
@yaahc I'm done with the implementation now, so there shouldn't be any more RFC changes. (Or if there are, I'll open a new pull request.) |
2 tasks
|
Do we need another review from @yaahc or are we good to merge this one now? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rendered
Status
First draft of reference-level design, focusing on the implementation.
Revised draft of summary, motivation, and guide-level explanation.
I haven't started the test plan yet.
There are some notes in the remaining sections.
Motivation
We need a design for contextual validation of the proof of work difficulty threshold.
Solution
The RFC should focus on Contextual Difficulty Validation, and summarise the Difficulty Validation Service Request in enough detail to justify the relevant design decisions.
Contextual Difficulty Validation - First Alpha
A synchronous contextual verifier that takes a block header (not a full block), and returns a Result that says if the difficulty threshold in the header matches the difficulty adjustment specified by the consensus rules.
Definitions
Consensus Rules
Guide-Level Explanation
Detailed Reference Design
Module Structure
zebra_chain::work::difficulty(existing module)zebra_consensus::block::checkFollow Up
Difficulty Validation Service Request - see #1166
Related Work