Implement Expanded to Compact Difficulty Conversion #1196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the derive, and generate values from random block hashes.
And cleanup some duplicate test code
Remove AddAssign for Work Rewrite a proptest using Sub for PartialCumulativeWork Use Arbitrary for Work Fix an Arbitrary for Work bug
teor2345
added
A-consensus
yaahc
reviewed
Oct 22, 2020
teor2345
commented
Oct 23, 2020
zebra-chain/src/work/arbitrary.rs
Outdated
Comment on lines
37
to
39
| ExpandedDifficulty::from_hash(&block::Hash(bytes)) | ||
| .to_compact() | ||
| .into() |
There was a problem hiding this comment.
Suggested change
| ExpandedDifficulty::from_hash(&block::Hash(bytes)) | |
| .to_compact() | |
| .into() | |
| Some(ExpandedDifficulty::from_hash(&block::Hash(bytes)) | |
| .to_compact()) |
This change makes sure that rejected work values don't disable property tests on other types.
This was referenced Oct 28, 2020
|
I opened #1231 to follow up the Windows failure at: I'll close and re-open the PR to re-run the checks. |
yaahc
approved these changes
Oct 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We need to check if the compact difficulty in the block header satisfies the difficulty adjustment contextual validation rules.
Those rules require us to perform calculations on
U256expanded difficulty values, and convert the results toCompactDifficulty.This PR covers the first stage of these checks: converting expanded to compact difficulty.
(And adds a bunch of tests and cleanups.)
The next step is to design contextual validation for difficulty, see ticket #1036.
Solution
Related Issues
Difficulty Tracking #802
Difficulty Contextual Validation Design #1036
Other Resources
zcashd implementation: