-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to the latest version of Abscissa (0.7 or later) #5502
Comments
Thanks! We're unlikely to do this any time soon, because we've replaced abscissa components with our own custom versions instead. |
Abscissa 0.5 is likely to cause Rust compiler errors in the Rust 2024 edition: So we might want to migrate some time in the next year. |
I bumped this up to medium because we can't disable the warning just for abscissa, we have to disable all warnings about any future incompatibility: |
@mpguerra we might want to schedule this work after the audit, because we needed to turn off warnings about all upcoming Rust changes until we fix this issue. (We couldn't just turn off this specific warning.) |
@mpguerra we might want to schedule this work before the first stable release, because it will change how command-line arguments work. We might be able to emulate the old arguments, or we might not. Even if we could emulate the same argument processing, we might want to do a breaking change and make them more consistent. |
It will also help us get rid of some insecure outdated dependencies. (Which we never call, but still appear in our dependency tree.) Some of those dependencies are listed in #6391 |
This is already in the Zebra Stable Release Epic which is intended for anything that needs to be completed before we tag a stable release |
Hey team! Please add your planning poker estimate with Zenhub @arya2 @conradoplg @dconnolly @oxarbitrage @teor2345 @upbqdn |
Since this is quite a large one, let's move it until after the audit |
Motivation
We need to update our command-line argument parsing to bump abscissa_core from 0.5.2 to 0.7.0 or later.
This is also needed to make the output of the
--help
flag andhelp
command consistent with that of invalid options or commands, by replacinggumdrop
withclap
.It is also needed to avoid a compilation error that is likely to be added to the Rust 2024 edition:
rust-lang/rust#79813
This error is currently a warning on
nightly
.Security
This will fix a low-severity security issue - we don't actually call the vulnerable abscissa 0.5.2 or tracing-subscriber 0.1.6 code, so it's only an issue at startup.
It will also make our dependency tree smaller, which improves compile speed, binary size, and security.
Vulnerability:
GHSA-wcg3-cvx6-7396
time-rs/time#293
Fix:
chronotope/chrono#602 (comment)
Steps
Migration guide
a. Consider replacing Zebra's custom
tokio
andmetrics
components with the current Abscissa implementationsRelated Work
The text was updated successfully, but these errors were encountered: