Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use BestChainUtxo rather than AwaitUtxo in the mempool transaction validator #5386

Closed
Tracked by #5234
teor2345 opened this issue Oct 11, 2022 · 1 comment · Fixed by #5616
Closed
Tracked by #5234

Use BestChainUtxo rather than AwaitUtxo in the mempool transaction validator #5386

teor2345 opened this issue Oct 11, 2022 · 1 comment · Fixed by #5616
Assignees
@arya2
Labels
A-consensus Area: Consensus rule updates A-rust Area: Updates to Rust code A-state Area: State / database changes C-bug Category: This is a bug I-consensus Zebra breaks a Zcash consensus rule

Comments

@teor2345
Copy link
Contributor

teor2345 commented Oct 11, 2022 •
edited
Loading

Motivation

The getblocktemplate RPC collects the transactions in the mempool into a block.
That block must be contextually valid based on the best tip in the state.

We can't use AwaitUtxo for validating mempool transactions, because it gets UTXOs from any chain or any queue.

Design

Use BestChainUtxo rather than AwaitUtxo to verify mempool transactions.
(Block transactions should still use AwaitUtxo.)
@teor2345 teor2345 mentioned this issue Oct 11, 2022
Closed
34 tasks
@teor2345 teor2345 changed the title use BestChainUtxo rather than AwaitUtxo in the mempool transaction validator Use BestChainUtxo rather than AwaitUtxo in the mempool transaction validator Oct 11, 2022
@teor2345 teor2345 added C-bug Category: This is a bug A-consensus Area: Consensus rule updates A-rust Area: Updates to Rust code P-Medium ⚡ I-consensus Zebra breaks a Zcash consensus rule A-state Area: State / database changes labels Oct 11, 2022
@mpguerra
Copy link
Contributor

Hey team! Please add your planning poker estimate with Zenhub @arya2 @conradoplg @oxarbitrage @teor2345 @upbqdn

@arya2 arya2 self-assigned this Nov 9, 2022
@arya2 arya2 mentioned this issue Nov 10, 2022
Merged
5 tasks
@mergify mergify bot closed this as completed in #5616 Nov 11, 2022
@dimxy dimxy mentioned this issue Mar 25, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arya2 arya2

Labels
A-consensus Area: Consensus rule updates A-rust Area: Updates to Rust code A-state Area: State / database changes C-bug Category: This is a bug I-consensus Zebra breaks a Zcash consensus rule
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

change(consensus) verify that mempool transaction UTXOs are in the best chain ZcashFoundation/zebra
3 participants
@mpguerra @arya2 @teor2345