Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use BestChainUtxo rather than AwaitUtxo in the mempool transaction validator #41

Closed
dimxy opened this issue Mar 25, 2023 · 0 comments · Fixed by #43
Closed

Use BestChainUtxo rather than AwaitUtxo in the mempool transaction validator #41

dimxy opened this issue Mar 25, 2023 · 0 comments · Fixed by #43
Assignees

Comments

@dimxy
Copy link
Collaborator

dimxy commented Mar 25, 2023

We can't use AwaitUtxo for validating mempool transactions, because it gets UTXOs from any chain or any queue.
We should use BestChainUtxo request rather than AwaitUtxo to verify mempool transactions (like in the original komodod transactions sent to mempool are checked against the coin cache which is populated from the active chain).
(Block transactions should still use AwaitUtxo.)

See the original issue description: ZcashFoundation#5386

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant