Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Propagate errors from the node's internal Service to the PeerServer. #50

Closed
hdevalence opened this issue Oct 7, 2019 · 0 comments · Fixed by #56
Closed

Propagate errors from the node's internal Service to the PeerServer. #50

hdevalence opened this issue Oct 7, 2019 · 0 comments · Fixed by #56

Comments

@hdevalence
Copy link
Contributor

The current PeerServer code from #17 does not propagate errors from the node's internal tower service. It should propagate them instead of dropping them on the floor.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Handle error conversions properly. ZcashFoundation/zebra
1 participant
@hdevalence