Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send mined transaction IDs to mempool storage for removal #2713

Closed
Tracked by #2309
teor2345 opened this issue Aug 31, 2021 · 4 comments · Fixed by #2827
Closed
Tracked by #2309

Send mined transaction IDs to mempool storage for removal #2713

teor2345 opened this issue Aug 31, 2021 · 4 comments · Fixed by #2827
Assignees

Comments

@teor2345
Copy link
Contributor

teor2345 commented Aug 31, 2021

Motivation

Zebra needs to remove mined transaction IDs from the mempool, whenever the state tip Grows.

Design

Tasks can await tip changes using ChainTipChange::tip_change and TipAction::Grow:

pub async fn tip_change(&mut self) -> Result<TipAction, watch::error::RecvError> {

We currently don't have a method on mempool::Storage to remove members of the mempool for whatever reason, so that will have to be done to support this.

@mpguerra
Copy link
Contributor

mpguerra commented Sep 1, 2021

@mpguerra mpguerra added this to the 2021 Sprint 19 milestone Sep 15, 2021
@dconnolly
Copy link
Contributor

Does this conflict with #2682 ?
Let's close this one in favor of that one

@dconnolly dconnolly removed this from the 2021 Sprint 19 milestone Sep 20, 2021
@teor2345
Copy link
Contributor Author

I think the conflict is with #2631 - if we do #2631, this ticket is redundant.
(And #2631 is better, and more similar to existing code like #2682.)

@teor2345 teor2345 reopened this Oct 4, 2021
@teor2345
Copy link
Contributor Author

teor2345 commented Oct 4, 2021

We removed #2631 from the sprint, so we need to add this ticket back in.

@mpguerra mpguerra added this to the 2021 Sprint 20 milestone Oct 4, 2021
@teor2345 teor2345 self-assigned this Oct 5, 2021
@teor2345 teor2345 changed the title Send mined transaction IDs to mempool storage for rejection Send mined transaction IDs to mempool storage for removal Oct 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants