-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Send committed spent OutPoints & nullifiers to the mempool for rejection #2631
Comments
Hey team! Please add your planning poker estimate with ZenHub @conradoplg @dconnolly @jvff @oxarbitrage @teor2345 @upbqdn |
Should we close this one? #2694 seems to say that we're not going to follow this design |
That ticket description is outdated - it was based on the initial mempool scope. So we should implement this ticket eventually, because it fixes some bugs in our mempool implementation. |
I also think we should reset the estimate on this ticket, because a lot of the changes we need are already implemented. |
Motivation
We need to get a list of recently committed spent outpoints & nullifiers from the state service, so we can evict any mempool transactions that also spend/reveal them.
This fixes some subtle bugs:
1
spendsB
andC
- it gets in the mempool2
only spendsB
- it gets mined into the chain, but transaction1
is not rejected from the mempoolzcashd
3
only spendsC
- it is rejected from the mempool, but it should be acceptedzcashd
would acceptConstraints
These rejections should persist until a chain reset, because:
The text was updated successfully, but these errors were encountered: