Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate bindingSigOrchard for Transaction::V5 #2103

Closed
dconnolly opened this issue May 4, 2021 · 0 comments · Fixed by #2441
Closed

Validate bindingSigOrchard for Transaction::V5 #2103

dconnolly opened this issue May 4, 2021 · 0 comments · Fixed by #2441
Assignees
@oxarbitrage
Labels
A-consensus Area: Consensus rule updates A-rust Area: Updates to Rust code NU-5 Network Upgrade: NU5 specific tasks
Milestone
2021 Sprint 15

Comments

@dconnolly
Copy link
Contributor

dconnolly commented May 4, 2021 •
edited
Loading

Very similar to how we've done this in the TransactionVerifier service, for V5, we compute the binding verification key and use it to verify the binding_sig:

image
https://zips.z.cash/protocol/protocol.pdf#txnencodingandconsensus

Related:
#1895
#1939
@dconnolly dconnolly added A-consensus Area: Consensus rule updates A-rust Area: Updates to Rust code NU-5 Network Upgrade: NU5 specific tasks labels May 4, 2021
@dconnolly dconnolly self-assigned this May 4, 2021
@dconnolly dconnolly mentioned this issue May 4, 2021
Closed
14 tasks
@mpguerra mpguerra mentioned this issue May 5, 2021
Closed
53 tasks
@dconnolly dconnolly mentioned this issue Jun 16, 2021
Closed
1 task
@jvff jvff mentioned this issue Jul 7, 2021
Closed
@teor2345 teor2345 mentioned this issue Jul 12, 2021
Merged
3 tasks
oxarbitrage added a commit to oxarbitrage/zebra that referenced this issue Aug 12, 2021
@oxarbitrage
remove ZcashFoundation#2103 from the TODO list
a19e73f
dconnolly pushed a commit that referenced this issue Aug 16, 2021
@oxarbitrage
Add orchard binding_verification_key (#2441)
c3c3023 
* add orchard binding_verification_key

* Merge branch 'main' into issue2102

* Merge branch 'main' into issue2102

* fix the build

* Merge branch 'main' into issue2102

* Merge branch 'main' into issue2102

* Fix docs

Co-authored-by: Deirdre Connolly <[email protected]>

* Merge branch 'main' into issue2102

* rustfmt

* readd binding validation

* remove #2103 from the TODO list

* Merge branch 'main' into issue2102
@mpguerra mpguerra mentioned this issue Dec 16, 2021
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oxarbitrage oxarbitrage

Labels
A-consensus Area: Consensus rule updates A-rust Area: Updates to Rust code NU-5 Network Upgrade: NU5 specific tasks
Projects
None yet
Milestone
2021 Sprint 15
Development

Successfully merging a pull request may close this issue.

Add orchard binding_verification_key oxarbitrage/zebra
4 participants
@dconnolly @mpguerra @teor2345 @oxarbitrage