Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure GetAddr fingerprinting is not possible. #18

Closed
hdevalence opened this issue Sep 20, 2019 · 1 comment · Fixed by #97
Closed

Ensure GetAddr fingerprinting is not possible. #18

hdevalence opened this issue Sep 20, 2019 · 1 comment · Fixed by #97
Assignees

Comments

@hdevalence
Copy link
Contributor

Cf. https://github.com/zcash/zcash/blob/128d863fb8be39ee294fda397c1ce3ba3b889cb2/src/main.cpp#L6024-L6028

@hdevalence
Copy link
Contributor Author

The current design guarantees that remote peers cannot inject data into our address book, because the only address book exposed outside of the network crate is the one that has information on the peers we're actually connected to.

However, the downside of only having "authenticated" (in the sense that addresses are real peers we've talked to) data is that the address book contains exact timestamps on peers we connected to. To address this, we probably want to:

  1. Truncate timestamps in outbound address data to a large time interval (say 30 minutes or so? but not so large that zcashd becomes unhappy);
  2. Randomize the order of outbound addresses or otherwise ensure that the truncated addresses are not sent in last-seen order.

@hdevalence hdevalence self-assigned this Nov 13, 2019
skyl added a commit to skyl/zebra that referenced this issue Sep 25, 2024
## What

Fund pages with 2Z or Zcash

## Why

Make 2Zs useful - hopefully make the new user flow more intuitive and
easy - no Zcash required.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant