Skip to content

Commit

Permalink
fix(clippy): Silence future-incompat warnings until we upgrade Abscis…
Browse files Browse the repository at this point in the history
…sa (#6024)

* Silence future-incompat warnings until we upgrade Abscissa

* Add missing cargo and clippy configs to workflow triggers
  • Loading branch information
teor2345 authored Jan 24, 2023
1 parent c92f7b0 commit dd90f79
Show file tree
Hide file tree
Showing 4 changed files with 21 additions and 4 deletions.
12 changes: 9 additions & 3 deletions .cargo/config.toml
Original file line number Diff line number Diff line change
@@ -1,5 +1,11 @@
# Zebra cargo configuration

# Disabled until we upgrade to abscissa 0.7 or later:
# https://github.com/ZcashFoundation/zebra/issues/5502
# https://doc.rust-lang.org/cargo/reference/future-incompat-report.html
[future-incompat-report]
frequency = "never"

# Flags that apply to all Zebra crates and configurations
[target.'cfg(all())']
rustflags = [
Expand Down Expand Up @@ -38,7 +44,7 @@ rustflags = [
# Incomplete code
"-Wclippy::dbg_macro",
"-Wclippy::todo",

# Manual debugging output.
# Use tracing::trace!() or tracing::debug!() instead.
"-Wclippy::print_stdout",
Expand All @@ -51,13 +57,13 @@ rustflags = [
# Panics
"-Wclippy::fallible_impl_from",
"-Wclippy::unwrap_in_result",

# Documentation
"-Wmissing_docs",

# These rustdoc -A and -W settings must be the same as the RUSTDOCFLAGS in:
# https://github.com/ZcashFoundation/zebra/blob/main/.github/workflows/lint.yml#L152

# Links in public docs can point to private items.
"-Arustdoc::private_intra_doc_links",

Expand Down
8 changes: 7 additions & 1 deletion .github/workflows/continous-integration-os.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,11 +19,14 @@ on:
# production code and test code
- '**/*.rs'
# hard-coded checkpoints
# TODO: skip proptest regressions
# TODO: skip proptest regressions?
- '**/*.txt'
# test data snapshots
- '**/*.snap'
# dependencies
- '**/Cargo.toml'
- '**/Cargo.lock'
- '**/deny.toml'
# configuration files
- '.cargo/config.toml'
- '**/clippy.toml'
Expand All @@ -41,6 +44,9 @@ on:
- '**/Cargo.toml'
- '**/Cargo.lock'
- '**/deny.toml'
# configuration files
- '.cargo/config.toml'
- '**/clippy.toml'
# workflow definitions
- '.github/workflows/continous-integration-os.yml'

Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/coverage.yml
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,8 @@ on:
- '**/*.snap'
- '**/Cargo.toml'
- '**/Cargo.lock'
- '.cargo/config.toml'
- '**/clippy.toml'
- 'codecov.yml'
- '.github/workflows/coverage.yml'

Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/docs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,9 @@ on:
- '**/*.rs'
- '**/Cargo.toml'
- '**/Cargo.lock'
# configuration files
- '.cargo/config.toml'
- '**/clippy.toml'
# workflow definitions
- '.github/workflows/docs.yml'

Expand Down

0 comments on commit dd90f79

Please sign in to comment.