Skip to content

Commit

Permalink
fix(ci): Build zebrad with Rust 1.63 to avoid Zcash parameter downloa…
Browse files Browse the repository at this point in the history
…d hangs (#5251)

* Try running coverage with Rust 1.63

* Run GitHub Actions tests with Rust 1.63

* Change from stable to 1.63 in the patch file

* Use Rust 1.63 to download Zcash parameters

* Use Rust 1.63 to build Docker zebrad images

* Make Rust 1.63 a supported platform, and make stable temporarily unsupported
  • Loading branch information
teor2345 authored Sep 26, 2022
1 parent 2465f4b commit 9cb6c55
Show file tree
Hide file tree
Showing 6 changed files with 16 additions and 5 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/continous-integration-os.patch.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ jobs:
matrix:
# TODO: Windows was removed for now, see https://github.com/ZcashFoundation/zebra/issues/3801
os: [ubuntu-latest, macos-latest]
rust: [stable, beta]
rust: [1.63, beta]
exclude:
- os: macos-latest
rust: beta
Expand Down
3 changes: 2 additions & 1 deletion .github/workflows/continous-integration-os.yml
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,8 @@ jobs:
matrix:
# TODO: Windows was removed for now, see https://github.com/ZcashFoundation/zebra/issues/3801
os: [ubuntu-latest, macos-latest]
rust: [stable, beta]
# Rust 1.64 hangs when downloading the Zcash Parameters on GitHub Actions runners
rust: [1.63, beta]
exclude:
# TODO: re-enable beta Rust tests on ubuntu (#4929)
- os: ubuntu-latest
Expand Down
3 changes: 2 additions & 1 deletion .github/workflows/coverage.yml
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,8 @@ jobs:

- uses: actions-rs/[email protected]
with:
toolchain: stable
# Rust 1.64 hangs when downloading the Zcash Parameters on GitHub Actions runners
toolchain: 1.63
override: true
profile: minimal
components: llvm-tools-preview
Expand Down
9 changes: 9 additions & 0 deletions book/src/user/supported-platforms.md
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,15 @@ ensures that each tier 1 platform builds and passes tests after each change.

For the full requirements, see [Tier 1 platform policy](platform-tier-policy.md#tier-1-platform-policy) in the Platform Tier Policy.

| platform | os | notes | rust | artifacts
| -------|-------|-------|-------|-------
| `x86_64-unknown-linux-gnu` | [Debian 11](https://www.debian.org/releases/bullseye/) | 64-bit | [1.63](https://github.com/rust-lang/rust/releases) | Docker

### Temporarily Unsupported

Zcash parameter downloads currently [hang when built with Rust 1.64 and later](https://github.com/ZcashFoundation/zebra/issues/5091).
Those Rust versions are unsupported until that bug is fixed.

| platform | os | notes | rust | artifacts
| -------|-------|-------|-------|-------
| `x86_64-unknown-linux-gnu` | [Debian 11](https://www.debian.org/releases/bullseye/) | 64-bit | [latest stable release](https://github.com/rust-lang/rust/releases) | Docker
Expand Down
2 changes: 1 addition & 1 deletion docker/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
# - runtime: is our runtime environment
#
# This stage implements cargo-chef for docker layer caching
FROM rust:bullseye as chef
FROM rust:1.63-bullseye as chef
RUN cargo install cargo-chef --locked
WORKDIR /opt/zebrad

Expand Down
2 changes: 1 addition & 1 deletion docker/zcash-params/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# This steps implement cargo-chef for docker layer caching
# This image is for caching Zcash Sprout and Sapling parameters
FROM rust:bullseye as chef
FROM rust:1.63-bullseye as chef
RUN cargo install cargo-chef --locked
WORKDIR /opt/zebrad

Expand Down

0 comments on commit 9cb6c55

Please sign in to comment.