Skip to content

Commit

Permalink
Remove broken ci-success check
Browse files Browse the repository at this point in the history
Previously, Zebra made ci-success a required check for merges to main. And then we made ci-success depend on a bunch of other CI checks.

But this doesn't work as expected, because if the dependent checks fail, ci-success is skipped, and the branch protection rules allow the branch to be merged to main.
  • Loading branch information
teor2345 authored Apr 29, 2021
1 parent 9fc2388 commit 63389d5
Showing 1 changed file with 0 additions and 12 deletions.
12 changes: 0 additions & 12 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,18 +9,6 @@ on:

jobs:

ci-success:
name: 🏁
runs-on: ubuntu-latest
needs:
- test
- build
- build-chain-no-features
- clippy
- fmt
steps:
- run: exit 0

test:
name: Test (+${{ matrix.rust }}) on ${{ matrix.os }}
# The large timeout is to accommodate Windows builds
Expand Down

0 comments on commit 63389d5

Please sign in to comment.