feat: advantage for supporting 3rd provider #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dadiorchen
commented
May 21, 2022
Comment on lines
+59
to
+73
| * Good, because with supporting popular provider like Google, Facebook, the end user to Greenstand don't need to maintain the account on Greenstand, and the account creation workflow could be smoother and safer. It is like: | ||
|
|
||
| 1. End user try to login to Greenstand | ||
| 2. End user selects the provider and authorize the application. | ||
| 3. The administrator of Greenstand receives the notification. | ||
| 4. The administrator of Greenstand confirm the end user, and assign the user appropriate role/permission. | ||
|
|
||
| Without this support: | ||
|
|
||
| 1. End user give the administrator their info. | ||
| 2. Administrator receive the info and create user, password, assign the user appropriate role/permission. | ||
| 3. The administrator give the user the account along with password. | ||
|
|
||
| So the former have no password and detailed user info exchange; | ||
|
|
There was a problem hiding this comment.
There was a problem hiding this comment.
I'm excited to suport google or facebook, I think Seba will feel the same way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.