Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Analyzer sdk bump #2

Merged
merged 3 commits into from
Apr 17, 2020
Merged

Conversation

baronfel
Copy link
Contributor

Proposed Changes

This updates the Analyzer SDK to the latest version, compatible with the most up-to-date version of FCS.
It also provides a docker-compose file for a test PG 12 database to run the tests against, as well as brief documentation about how to use it. After this change, I believe the analyzer will not run on prior versions of the analyzer CLI/SDK (due to breaking FCS API changes), but it will run on updated analyzer SDK/CLI versions. Therefore you might want to hold off on merge/release of this PR until a version of Ionide launches with support (you can watch ionide/FsAutoComplete#590 for details on this effort)

Types of changes

What types of changes does your code introduce to BinaryDefense.FSharp.Analyzers?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • Build and tests pass locally
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added necessary documentation (if appropriate)

@Zaid-Ajaj Zaid-Ajaj merged commit ca8053a into Zaid-Ajaj:master Apr 17, 2020
@Zaid-Ajaj
Copy link
Owner

Thanks a lot for updates and sorry for the delay 🙏

I have published a new version as of v3.3.0 🚀 and it will be available soon on nuget 😄

Zaid-Ajaj pushed a commit that referenced this pull request Dec 8, 2020
Zaid-Ajaj pushed a commit that referenced this pull request Aug 9, 2021
sync with latest changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants