Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass query parameters to playlist downloader #679

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

Top-Cat
Copy link
Contributor

@Top-Cat Top-Cat commented Dec 2, 2024

Scope

Pass query parameters from playlist oneclick handler to the service that downloads the playlist.

Example:

bsplaylist://playlist/https://api.beatsaver.com/playlists/id/12272/download?exp=1733163270&sig=db9ba0699986f368

Currently this would be stripped to: https://api.beatsaver.com/playlists/id/12272/download
But after this change the exp and sig fields don't get removed and oneclick just works™️

Screenshots

before after
Screenshot 2024-12-02 at 18 21 28 Screenshot 2024-12-02 at 18 26 03

How to Test

Copy link

sonarcloud bot commented Dec 2, 2024

Copy link
Owner

@Zagrios Zagrios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me 🙌

@Zagrios
Copy link
Owner

Zagrios commented Dec 2, 2024

It's working perfectly fine, thanks a lot @Top-Cat ❤️
This will be released very soon in v1.4.14

@Zagrios Zagrios merged commit 127a538 into Zagrios:master Dec 2, 2024
5 checks passed
Zagrios added a commit that referenced this pull request Dec 2, 2024
Pass query parameters to playlist downloader

(cherry picked from commit 127a538)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants