fix(remote-os-configure): Align command with recent Ansible playbooks…

… dry_run support (reboot excluded at the playbook YAML)

provisioner_examples_plugin/provisioner_examples_plugin/ansible/hello_world_runner.py

@@ -97,11 +97,9 @@ def _print_pre_run_instructions(self, printer: Printer, prompter: Prompter):
 
     def _prerequisites(self, ctx: Context, checks: Checks) -> None:
         if ctx.os_arch.is_linux():
-            checks.check_tool_fn("docker")
-
+            return
         elif ctx.os_arch.is_darwin():
-            checks.check_tool_fn("docker")
-
+            return
         elif ctx.os_arch.is_windows():
             raise NotImplementedError("Windows is not supported")
         else:

provisioner_examples_plugin/pyproject.toml

@@ -79,7 +79,7 @@ diagrams = "^0.22.0"
 ruff = "^0.0.265"
 
 # For debugging purposes when running "poetry run provisioner" from within the plugins folder
-# provisioner = { path = "../../provisioner/provisioner", develop = true }
+provisioner = { path = "../../provisioner/provisioner", develop = true }
 
 [build-system]
 requires = ["poetry-core>=1.0.0"]

provisioner_installers_plugin/pyproject.toml

@@ -76,7 +76,7 @@ diagrams = "^0.22.0"
 ruff = "^0.0.265"
 
 # For debugging purposes when running "poetry run provisioner" from within the plugins folder
-# provisioner = { path = "../../provisioner/provisioner", develop = true }
+provisioner = { path = "../../provisioner/provisioner", develop = true }
 
 [build-system]
 requires = ["poetry-core>=1.0.0"]

provisioner_single_board_plugin/provisioner_single_board_plugin/common/remote/remote_network_configure.py

@@ -154,8 +154,7 @@ def _run_ansible_network_configure_playbook_with_progress_bar(
                 ansible_tags=[
                     "configure_rpi_network",
                     "define_static_ip",
-                    "reboot" if not args.remote_opts.get_remote_context().is_dry_run() else "",
-                ],
+                ] + (["reboot"] if not args.remote_opts.get_remote_context().is_dry_run() else []),
             ),
             desc_run="Running Ansible playbook (Configure Network)",
             desc_end="Ansible playbook finished (Configure Network).",
@@ -230,11 +229,9 @@ def _bundle_network_information_from_tuple(
 
     def _prerequisites(self, ctx: Context, checks: Checks) -> None:
         if ctx.os_arch.is_linux():
-            checks.check_tool_fn("docker")
-
+            return 
         elif ctx.os_arch.is_darwin():
-            checks.check_tool_fn("docker")
-
+            return 
         elif ctx.os_arch.is_windows():
             raise NotImplementedError("Windows is not supported")
         else:

provisioner_single_board_plugin/provisioner_single_board_plugin/common/remote/remote_os_configure.py

@@ -81,8 +81,11 @@ def _run_ansible_configure_os_playbook_with_progress_bar(
                 ansible_vars=[f"host_name={ansible_host.host}"],
                 ansible_tags=[
                     "configure_remote_node",
-                    "reboot" if not args.remote_opts.get_remote_context().is_dry_run() else "",
-                ],
+                    "reboot"
+                ]
+                # ansible_tags=[
+                #     "configure_remote_node",
+                # ] + (["reboot"] if not args.remote_opts.get_remote_context().is_dry_run() else []),
             ),
             desc_run="Running Ansible playbook (Configure OS)",
             desc_end="Ansible playbook finished (Configure OS).",
@@ -118,11 +121,9 @@ def _print_post_run_instructions(
 
     def _prerequisites(self, ctx: Context, checks: Checks) -> None:
         if ctx.os_arch.is_linux():
-            checks.check_tool_fn("docker")
-
+            return
         elif ctx.os_arch.is_darwin():
-            checks.check_tool_fn("docker")
-
+            return
         elif ctx.os_arch.is_windows():
             raise NotImplementedError("Windows is not supported")
         else:

provisioner_single_board_plugin/pyproject.toml

@@ -77,7 +77,7 @@ diagrams = "^0.22.0"
 ruff = "^0.0.265"
 
 # For debugging purposes when running "poetry run provisioner" from within the plugins folder
-# provisioner = { path = "../../provisioner/provisioner", develop = true }
+provisioner = { path = "../../provisioner/provisioner", develop = true }
 
 [build-system]
 requires = ["poetry-core>=1.0.0"]