add manifest for CZIcmd and add Windows-ARM64-build #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a new XML manifest file `CZIcmd.manifest` to enable support for long paths in the application by setting the `longPathAware` attribute to `true`. Introduced a new resource script file `CZIcmd.rc` with SPDX license information, headers, resource symbols, version details, company and product information, and an application icon resource. Created a new header file `resource_data.h.in` to define version-related macros and file description strings, using placeholders for dynamic replacement during the build process.
Updated CMakeLists.txt to include new source files for the CZIcmd target, set the C++ standard to C++14, and added platform-specific handling for Windows with manifest and resource files. Configured project description and resource data generation. Added installation rule for the CZIcmd executable.
Modified `cmake.yml` to trigger the workflow on pushes to any branch by changing the `branches` key under the `push` event to `**`. This allows the workflow to run for pushes to all branches, providing more flexibility in CI/CD processes.
Introduced new variables `czicmd_VERSION_MAJOR`, `czicmd_VERSION_MINOR`, and `czicmd_VERSION_PATCH` in `CMakeLists.txt`. These variables are set using the corresponding version variables from `libCZI` to ensure consistent versioning across the project.
Updated CMakeLists.txt to increment libCZI version from 0.62.1 to 0.62.2. Added a new entry in version-history.markdown for 0.62.2, noting the enablement of long paths on Windows for CZIcmd.
Updated cmake.yml to improve clarity and organization of the build process for Windows x64, Windows ARM64, and Ubuntu. - Specified architecture in Windows CMake configuration steps. - Split build steps into separate jobs for each platform. - Added conditions to ensure correct build commands for each OS and architecture. - Used distinct build directories for Windows x64 and ARM64 to avoid conflicts. - Separated Azurite installation from CMake steps for better clarity.
Updated `cmake.yml` to use `$env:VCPKG_INSTALLATION_ROOT` instead of `${VCPKG_INSTALLATION_ROOT}` for correct environment variable referencing in PowerShell for both Windows x64 and Windows ARM64 builds.
Updated CMake configuration for Windows ARM64 to include `CRASH_ON_UNALIGNED_ACCESS=OFF` and `IS_BIG_ENDIAN=FALSE` for cross-compilation. Refined conditional statements for artifact preparation and upload by removing spaces around `matrix.build` condition. Enhanced clarity in `codecov-action` by adding parentheses around `github.repository` condition.
Modified `cmake.yml` to change the `artifactPath` for the Windows ARM64 build from `${{github.workspace}}/build/release/${name}` to `${{github.workspace}}/arm64build/release/${name}`. This ensures the artifact is correctly stored in the `arm64build` directory.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #116 +/- ##
=======================================
Coverage 65.50% 65.50%
=======================================
Files 86 86
Lines 10893 10893
=======================================
Hits 7136 7136
Misses 3757 3757
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
m-aXimilian
previously approved these changes
Sep 23, 2024
DaveyJonesBitPail
previously approved these changes
Sep 23, 2024
ptahmose
dismissed stale reviews from DaveyJonesBitPail and m-aXimilian
via
9a5c654
m-aXimilian
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Type of change
How Has This Been Tested?
locally
Checklist: