Add WorldRailgunPreFired and WorldRailFired virtual for railgun attacks #2824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add AttackLineFlags for WorldHitscanPreFired Indentation fixes in event.zs
|
If this gets added in, WorldThingRailFired definitely should become a thing and WorldThingHitscan(Pre)Fired should be removed from rail attacks. Reiterating what was stated on Discord. |
Cacodemon345
changed the title
|
This is a good idea. Since fundamentally railguns and other hitscans are different functions, and it would be a good idea to be able to differentiate between them anyway, I approve of just having two separate sets of events. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
WorldRailgunPreFiredvirtual for railgun attacks, which can block them likeWorldHitscanPreFiredby return values, andWorldRailgunFiredas the railgun-equivalent ofWorldHitscanFired.As
WorldHitscanPreFiredpasses all LineAttack parameters, its railgun equivalent has been made to do the same for consistency reasons.AttackLineFlagsis now used for LineAttack flags information instead ofDamageFlags.Indentation in
event.zshas been fixed again.