Fixes for serializing and initializing #2817
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed missing DViewPosition serializing. Fixed missing initializers in player_t.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Going off of #2796 earlier, this introduces some more potential safety barriers in the case that possible race conditions when playing online cause corrupted data to be used before it has a chance to be set correctly. It also fixes serializing being missing from Actor view positions. Upon further investigating I really don't have a strong lead as to what was causing players to not load in correctly in the instance there's multiple as it's hard to boil down to either a loading issue or networking issue.