Better error message for mismatching sorts in substitutions #6093
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When substituting expressions in the Z3 API, the error message in case of a sort mismatch was confusing:
In the above example, expression pairs were passed, only with the wrong type. This issue confused me a lot in my beginner times with Z3, and currently, it's confusing my students ;)
This pull request leads to the, in my opinion more meaningful, error message 'Z3 invalid substitution, mismatching "from" and "to" sorts.' in that case.