improved subset checking for regexes with counters #5731
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two main edits.
Some cases with counters caused divergence of unsat checking.
A common case is a regex with nested counting
(a{0,k})*
. where one getsdisjuncts of the form
a{0,k-1}(a{0,k})* | a{0,k-2}(a{0,k})*
but where the first one subsumes the second one.The PR extends the
is_subset
check to avoid the blowup (in some cases).The problem is in general very hard though.
The PR also fixes an issue with Antimitov form that allowed unions of conditionals with the same condition,
by simplifying them, essentally by turning
if(c, t1, e1) U if(c, t2, e2)
intoif(c, t1 U t2, e1 U e2)
A related test I intend to add to the regression tests is this (that would before the fix not terminate):
I'll also add a few variants of it for
unicode
as well asascii
encodings.