Rename 'user' to 'user_solver' #5586 #5587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jamiecollinson can you try this? |
Issue Z3Prover#5586 reported that Android builds (targetting, e.g., x86) failed to compile due to a conflict between: * `struct user` in `sys/user.h`; and * `namespace user` in z3's `user_solver.h` This issue is resolved by renaming `namespace user` to `namespace user_solver` (matching the header name) to avoid this conflict. Reported-by: Jamie Collinson <[email protected]> Signed-off-by: Andrew V. Jones <[email protected]>
aytey
changed the title
|
@andrewvaughanj - thanks, resolved #5586 for me (more details there). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #5586 reported that Android builds (targetting, e.g., x86) failed to compile due to a conflict between:
struct userinsys/user.h; andnamespace userin z3'suser_solver.hThis issue is resolved by renaming
namespace usertonamespace user_solver(matching the header name) to avoid this conflict.Reported-by: Jamie Collinson [email protected]
Signed-off-by: Andrew V. Jones [email protected]