Fixed linkopts -lstdc++ for ocaml bindings #2639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Edited META.in to include -lstd++ linking flag as per this stack overflow answer:
https://stackoverflow.com/questions/56839246/installing-ocaml-api-for-z3-using-opam/58398704
This may help #2558 #2355 both of which are in reference to c++ linking problems. I have experienced C++ linking issues on the latest version of z3 and this seemed to help.
There is some mention in mk_util.py that I do not completely understand and may want to be reviewed before accepting this pull request.
z3/scripts/mk_util.py
Line 1968 in 5122b2d
Note that dune users have to explicitly link libc++ as apparently the META file is partially ignored as per the stack overflow above.