-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Microsoft.Z3.xml missing in release package #4578
Comments
Signed-off-by: Nikolaj Bjorner <[email protected]>
Signed-off-by: Nikolaj Bjorner <[email protected]>
The .net bindings are now built using "dotnet build". These don't emit xml information, at least not by default. |
@NikolajBjorner That .xml contains the function-level documentation so that Visual Studio (and similar) can show it in tooltips, etc. Whatever is now used to build the packages, should also produce that file. I think this has the right instructions for .NET core: https://docs.microsoft.com/en-us/dotnet/csharp/codedoc |
Thanks for the pointer. It works. The next nightly will have xml included. |
@NikolajBjorner I'm just checking the latest nightly (commit 0aac7e54a91de423088f0f321b9eef1bbac87118 v4.8.10) and the xml documentation file is still missing. Same goes for the stable v4.8.9. This means that the VS IntelliSense is lacking as a result of that. Could we please re-open this? It seems it's still an issue... I'd also offer some help with this, but I checked the source code and don't see any issue there. What's strange to me is that the csproj in the source uses TFMs |
There exists some way to figure out how to include the right files. |
@NikolajBjorner What about the TFM inconsistency? Isn't it an issue that you build it for |
The nuget package for the nightly and release build is created by a different script. The script is here: Line 1662 in 8abb644
The nightly build now includes the xml file in the nupkg bundle. |
@NikolajBjorner Thank you very much for the quick XML doc fix, the nightly build seems ok, and this issue can be closed now. Any idea when we might expect a next stable release? The issue regarding the TFM I'm raising is that you build the code telling the compiler to build for |
But the script we use for the build is in z3/scripts/mk_util.py. The file https://github.com/Z3Prover/z3/blob/master/src/api/dotnet/Microsoft.Z3.csproj.in#L52 |
I plan to make an inaugural release by middle of next week. |
@NikolajBjorner I see, thank you for the clarification. Looking forward to the release, lot of great improvements in this one 🙂 |
this was fixed |
In past (e.g. 4.7.1) you include file Microsoft.Z3.xml file inside your release package. Now in current releases is this file missing. This file is important because it shows in Visual Studio help on commands.
The text was updated successfully, but these errors were encountered: