Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix upgrade #219

Draft
wants to merge 6 commits into
base: testing
Choose a base branch
from

Conversation

CodeShakingSheep
Copy link
Member

Don't replace config file

Problem

After the last update the contextmenu extension wasn't working anymore as the config/config.inc.php file had been overridden from the template file leading to the installed extensions not being present anymore after this line: https://github.com/YunoHost-Apps/roundcube_ynh/blob/master/conf/config.inc.php#L140

Solution

Keep config/config.inc.php and don't override it with the template.

PR Status

  • Code finished and ready to be reviewed/tested
  • The fix/enhancement were manually tested (if applicable)

Automatic tests

Automatic tests can be triggered on https://ci-apps-dev.yunohost.org/ after creating the PR, by commenting "!testme", "!gogogadgetoci" or "By the power of systemd, I invoke The Great App CI to test this Pull Request!". (N.B. : for this to work you need to be a member of the Yunohost-Apps organization)

ericgaspar and others added 2 commits August 5, 2024 10:03
* Update manifest.toml (YunoHost-Apps#206)

Upgrade php to v8.2

* Update _common.sh (YunoHost-Apps#207)

Upgrade carddav_version to 5.1.0

* Update DESCRIPTION_fr.md

* Auto-update READMEs

* Update DESCRIPTION.md

* Auto-update READMEs

* Update DESCRIPTION_fr.md

* Auto-update READMEs

* Update DESCRIPTION.md

* Auto-update READMEs

* Change source for roundcube (releases instead of archives)

* Update manifest.toml

* Update manifest.toml

* Auto-update READMEs

* Fixup autoupdate asset regex

* Auto-update READMEs

* Upgrade PHP version to 8.3 (YunoHost-Apps#216)

* Testing (YunoHost-Apps#213)

* Update manifest.toml (YunoHost-Apps#206)

Upgrade php to v8.2

* Update _common.sh (YunoHost-Apps#207)

Upgrade carddav_version to 5.1.0

* Update DESCRIPTION_fr.md

* Auto-update READMEs

* Update DESCRIPTION.md

* Auto-update READMEs

* Update DESCRIPTION_fr.md

* Auto-update READMEs

* Update DESCRIPTION.md

* Auto-update READMEs

* Change source for roundcube (releases instead of archives)

* Update manifest.toml

* Update manifest.toml

* Auto-update READMEs

---------

Co-authored-by: CodeShakingSheep <[email protected]>
Co-authored-by: yunohost-bot <[email protected]>
Co-authored-by: Jérémie Parisel <[email protected]>
Co-authored-by: Éric Gaspar <[email protected]>

* Update manifest.toml

Upgrade php to v8.3

---------

Co-authored-by: Alexandre Aubin <[email protected]>
Co-authored-by: yunohost-bot <[email protected]>
Co-authored-by: Jérémie Parisel <[email protected]>
Co-authored-by: Éric Gaspar <[email protected]>

* Update manifest.toml: fix autoupdate regex?

* Auto-update READMEs

* Upgrade to v1.6.8 (YunoHost-Apps#217)

* Upgrade sources
- `main` v1.6.8: https://github.com/roundcube/roundcubemail/releases/tag/1.6.8

* Auto-update READMEs

---------

Co-authored-by: CodeShakingSheep <[email protected]>
Co-authored-by: Alexandre Aubin <[email protected]>
Co-authored-by: yunohost-bot <[email protected]>
Co-authored-by: Alexandre Aubin <[email protected]>
Co-authored-by: Jérémie Parisel <[email protected]>
Co-authored-by: Mateusz <[email protected]>
Co-authored-by: YunoHost Bot <[email protected]>
Don't replace config file
@CodeShakingSheep CodeShakingSheep changed the base branch from master to testing August 10, 2024 20:13
@CodeShakingSheep
Copy link
Member Author

!testme

@yunohost-bot
Copy link
Contributor

🌻
Test Badge

@yunohost-bot
Copy link
Contributor

📚
Test Badge

Keep composer.json
@CodeShakingSheep
Copy link
Member Author

!testme

@yunohost-bot
Copy link
Contributor

Alrighty!
Test Badge

@yunohost-bot
Copy link
Contributor

🐛
Test Badge

Keep composer.lock
@CodeShakingSheep
Copy link
Member Author

!testme

@yunohost-bot
Copy link
Contributor

May the CI gods be with you!
Test Badge

@yunohost-bot
Copy link
Contributor

📚 🐛
Test Badge

--keep option doesn't support wildcards
@CodeShakingSheep
Copy link
Member Author

!testme

@yunohost-bot
Copy link
Contributor

📖
Test Badge

@yunohost-bot
Copy link
Contributor

Meow 🐈
Test Badge

@CodeShakingSheep
Copy link
Member Author

Meow 🐈 Test Badge

Upgrades fail because of an already existing table collected_contacts. Created a PR for it sblaisot/automatic_addressbook#31

@CodeShakingSheep CodeShakingSheep marked this pull request as draft August 28, 2024 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants