-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix upgrade #219
Draft
CodeShakingSheep
wants to merge
6
commits into
YunoHost-Apps:testing
Choose a base branch
from
CodeShakingSheep:no-config-override
base: testing
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Fix upgrade #219
CodeShakingSheep
wants to merge
6
commits into
YunoHost-Apps:testing
from
CodeShakingSheep:no-config-override
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update manifest.toml (YunoHost-Apps#206) Upgrade php to v8.2 * Update _common.sh (YunoHost-Apps#207) Upgrade carddav_version to 5.1.0 * Update DESCRIPTION_fr.md * Auto-update READMEs * Update DESCRIPTION.md * Auto-update READMEs * Update DESCRIPTION_fr.md * Auto-update READMEs * Update DESCRIPTION.md * Auto-update READMEs * Change source for roundcube (releases instead of archives) * Update manifest.toml * Update manifest.toml * Auto-update READMEs * Fixup autoupdate asset regex * Auto-update READMEs * Upgrade PHP version to 8.3 (YunoHost-Apps#216) * Testing (YunoHost-Apps#213) * Update manifest.toml (YunoHost-Apps#206) Upgrade php to v8.2 * Update _common.sh (YunoHost-Apps#207) Upgrade carddav_version to 5.1.0 * Update DESCRIPTION_fr.md * Auto-update READMEs * Update DESCRIPTION.md * Auto-update READMEs * Update DESCRIPTION_fr.md * Auto-update READMEs * Update DESCRIPTION.md * Auto-update READMEs * Change source for roundcube (releases instead of archives) * Update manifest.toml * Update manifest.toml * Auto-update READMEs --------- Co-authored-by: CodeShakingSheep <[email protected]> Co-authored-by: yunohost-bot <[email protected]> Co-authored-by: Jérémie Parisel <[email protected]> Co-authored-by: Éric Gaspar <[email protected]> * Update manifest.toml Upgrade php to v8.3 --------- Co-authored-by: Alexandre Aubin <[email protected]> Co-authored-by: yunohost-bot <[email protected]> Co-authored-by: Jérémie Parisel <[email protected]> Co-authored-by: Éric Gaspar <[email protected]> * Update manifest.toml: fix autoupdate regex? * Auto-update READMEs * Upgrade to v1.6.8 (YunoHost-Apps#217) * Upgrade sources - `main` v1.6.8: https://github.com/roundcube/roundcubemail/releases/tag/1.6.8 * Auto-update READMEs --------- Co-authored-by: CodeShakingSheep <[email protected]> Co-authored-by: Alexandre Aubin <[email protected]> Co-authored-by: yunohost-bot <[email protected]> Co-authored-by: Alexandre Aubin <[email protected]> Co-authored-by: Jérémie Parisel <[email protected]> Co-authored-by: Mateusz <[email protected]> Co-authored-by: YunoHost Bot <[email protected]>
Don't replace config file
!testme |
Keep composer.json
!testme |
Keep composer.lock
!testme |
--keep option doesn't support wildcards
!testme |
Upgrades fail because of an already existing table |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't replace config file
Problem
After the last update the contextmenu extension wasn't working anymore as the
config/config.inc.php
file had been overridden from the template file leading to the installed extensions not being present anymore after this line: https://github.com/YunoHost-Apps/roundcube_ynh/blob/master/conf/config.inc.php#L140Solution
Keep
config/config.inc.php
and don't override it with the template.PR Status
Automatic tests
Automatic tests can be triggered on https://ci-apps-dev.yunohost.org/ after creating the PR, by commenting "!testme", "!gogogadgetoci" or "By the power of systemd, I invoke The Great App CI to test this Pull Request!". (N.B. : for this to work you need to be a member of the Yunohost-Apps organization)