Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow custom config #203

Open
wants to merge 4 commits into
base: testing
Choose a base branch
from

Conversation

CodeShakingSheep
Copy link
Member

@CodeShakingSheep CodeShakingSheep commented May 27, 2024

Problem

I am using 3 additional plugins in my roundcube instance. However, as I had to add them in config/config.inc.php after each update they get disabled and I have to enable them again manually (by adding the plugins back to config/config.inc.php which is annoying.

Solution

Instead of adding plugins to config/config.inc.php enable option to add them to a custom config file config/<ROUNDCUBE_DOMAIN>.inc.php by adding $config['include_host_config'] = true; to config/config.inc.php.

With this setting additional plugins can be enabled like this in config/<ROUNDCUBE_DOMAIN>.inc.php:

array_push($this->prop['plugins'], 'html5_notifier');

See roundcube/roundcubemail#9458 (comment).

I have it working like this on my server flawlessly.

PR Status

  • Code finished and ready to be reviewed/tested
  • The fix/enhancement were manually tested (if applicable)

Automatic tests

Automatic tests can be triggered on https://ci-apps-dev.yunohost.org/ after creating the PR, by commenting "!testme", "!gogogadgetoci" or "By the power of systemd, I invoke The Great App CI to test this Pull Request!". (N.B. : for this to work you need to be a member of the Yunohost-Apps organization)

Allow custom config
Add instructions for installing additional plugins
@CodeShakingSheep
Copy link
Member Author

!testme

@yunohost-bot
Copy link
Contributor

📚
Test Badge

@yunohost-bot
Copy link
Contributor

🌻
Test Badge

@ericgaspar
Copy link
Member

Please don't use the README.md file. The README is generated automatically with the description.md. You can use DESCRIPTION.md or ADMIN.md

Update configuration section
This reverts commit 7876031.
@CodeShakingSheep
Copy link
Member Author

Please don't use the README.md file. The README is generated automatically with the description.md. You can use DESCRIPTION.md or ADMIN.md

Thanks for the hint @ericgaspar . I reverted the commit for the README.md and made adoptions in ADMIN.md instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants