Add notify push option #417

kay0u · 2021-06-08T18:17:26Z

Solution

Nextcloud comes with a "10x better performance" announcement which depends on an app, this PR aims to install it

PR Status

Code finished and ready to be reviewed/tested
The fix/enhancement were manually tested (if applicable)

Automatic tests

Automatic tests can be triggered on https://ci-apps-dev.yunohost.org/ after creating the PR, by commenting "!testme", "!gogogadgetoci" or "By the power of systemd, I invoke The Great App CI to test this Pull Request!". (N.B. : for this to work you need to be a member of the Yunohost-Apps organization)

manifest.json

kay0u · 2021-06-09T16:33:33Z

The more I implement it, the more I don't want it to see that PR merged.

There are so many ways to make this notify_push app not work.

conf/systemd.service

scripts/install

kay0u · 2021-06-09T16:50:40Z

!testme

yunohost-bot · 2021-06-09T16:50:42Z

😜

kay0u · 2021-06-10T08:40:46Z

!testme

yunohost-bot · 2021-06-10T08:40:48Z

✌️

kay0u · 2021-06-10T10:17:38Z

!testme

yunohost-bot · 2021-06-10T10:17:39Z

🚀

Thovi98 · 2021-11-02T10:43:51Z

Hello @kay0u
Thanks a lot for what you are doing here !!

The more I implement it, the more I don't want it to see that PR merged.

There are so many ways to make this notify_push app not work.

Do you think this PR will once be merged or is it better to setup notify-push by myself ? Thanks 😇

kay0u · 2021-11-05T11:15:39Z

Hello!

If you are comfortable with the command line, I think you can make the changes by hand.

I'd like the opinion of others app's group on it, because Nextcloud is one of the most used apps in YNH, it's already horrible to maintain, and there are errors with each new version, so any new features added to this package will be yet another part that can be an issue when upgrading.

Thovi98 · 2021-11-09T12:15:44Z

Thanks for your answer !

I'd like the opinion of others app's group on it, because Nextcloud is one of the most used apps in YNH, it's already horrible to maintain, and there are errors with each new version, so any new features added to this package will be yet another part that can be an issue when upgrading.

I am probably not the right person to answer this given my lack of knowledge, but my two cents :

notify_push is more a "nice to have" than a "must have" : Nextcloud already perfectly works without this app.
It becomes more useful when there are a lot of Nextcloud users : generally, maintainers of big instances can use the command line.

So, altough it’s not ideal for a Yunohost package, I would rather go to a documentation which explains how to install notify_push with the command line. I think it’s better to have a robust initial package that has faster updates than something complex...

But to help users as much as possible, we can pave the way by already prepare notify_push with the corresponding lines, but commented, in nginx, /etc/hosts, config.php, …

JocelynDelalande · 2022-03-03T00:43:53Z

FYI, about documenting an install process compatible with YNH (in french) : https://hackriculture.fr/nextcloud-synchronisation-de-fichiers-plus-performante-avec-notify_push-hpb.html

ericgaspar · 2022-07-03T09:54:52Z

!testme

yunohost-bot · 2022-07-03T09:54:54Z

🌻

ericgaspar · 2022-11-11T20:16:55Z

!testme

yunohost-bot · 2022-11-11T20:16:57Z

🌻

ericgaspar · 2023-02-13T22:02:57Z

!testme

yunohost-bot · 2023-02-13T22:03:01Z

🎠

doc/DISCLAIMER_fr.md

tomdereub · 2023-07-24T10:47:17Z

Hi, what's the status of this PR ? It seems that it's quite ready to merge, does it mean that you finally decided to integrate it to the package ?

kay0u · 2024-08-26T15:23:28Z

!testme

yunohost-bot · 2024-08-26T15:23:32Z

😜

yunohost-bot · 2024-08-26T15:23:32Z

🐛

…etries the cron job several times and catch catch the error on failure

cron can sometimes fail when the database is not fully initialized, r…

kay0u · 2024-08-27T12:27:55Z

Tested on my side, upgrade from the current version without this feature, enable notify_push via config panel, backup then restore. Notify push still working.

Ready to merge now

doc/ADMIN_fr.md

doc/ADMIN.md

Co-authored-by: eric_G <[email protected]>

* Update manifest.toml * Auto-update READMEs * add pre upgrade warning for NC 29 * update to PHP8.3 * Auto-update READMEs * Update manifest.toml * Auto-update READMEs * Fix space splitting in phpflags on install (#690) * Auto-update READMEs * Update upgrade * Update manifest.toml * Auto-update READMEs * Fix phpflags (#691) * Fix upgrade: php version is 8.3 starting from 29.x ? (#692) * Update manifest.toml * Auto-update READMEs * Update tests.toml * [autopatch] Do not delete logs on app removal (#697) * [autopatch] Do not delete logs on app removal (#698) Co-authored-by: Yunohost-Bot <> * 29.0.3 * Auto-update READMEs * Update remove * Indent * Fix again upgrade ending with Nextcloud being in PHP 8.2 ? * Auto-update READMEs * Update nginx.conf * Update manifest.toml * Auto-update READMEs * Rework DESCRIPTION.md (#707) * Update DESCRIPTION_fr.md * Auto-update READMEs * Update DESCRIPTION.md * Auto-update READMEs * Update DESCRIPTION_fr.md * Auto-update READMEs --------- Co-authored-by: yunohost-bot <[email protected]> * bump all old versions * oupsie * Auto-update READMEs * system_addressbook_exposed is a boolean * Auto-update READMEs * migrate system_addressbook_exposed to boolean, fix upgrade test * another fix for system_addressbook_exposed, update the dav conf accordingly * zblerg, do not modify system_addressbook_exposed config value in the upgrade script * add redis-server as deps * find files before chown them * chown the root folder too * fix find condition * find ... chmod is not faster, at least avoid to chown -R the data_dir in the upgrade script * add a button in the config panel to run chown/chmod on data_dir * we can avoid this chmod too i guess? * only nextcloud is allowed to read the config file * zblerg, the config file doesn't exist before install * wait until nginx has actually remove the nextcloud conf during upgrade before checking the url_handled * create a function for that * fix change-url dav detection * only if domain has changed... * Update scripts/_common.sh * moar sleep * oups * minor typos * Update backup * minor typos * Fix removing ACL permissions on uninstall According to `man setfacl`, for the `--remove` option "[o]nly ACL entries without the perms field are accepted as parameters". * Fix: Add missing `file` argument to `setfacl` * Fix: Use absolute path for removing ACL permissions * Update manifest.toml * Auto-update READMEs * Add notify push option (#417) * add notify_push option * self-test notify_push * fix notify_app * new permission hpb, some fixes * fix the restore script * fix restore² * fix upgrade * fix socket path * Update doc/DISCLAIMER_fr.md * split nginx conf * use official helpers with modified args * Auto-update READMEs * update nginx conf, add new services * add tests * add arch var * tests: enable_notify_push is false by default * fix upgrade * final_path -> install_dir * fix socket nginx path * add notify_push nginx conf before, so the reload in ynh_add_nginx_config load it * fully functional version * readd a removed fix * run cron task after notify push setup * Auto-update READMEs * remove systemd files * add notify push in config panel * add cron again because to make notify push happy * fix indent * enable/disable the notify push path * fix path unit * exec only for nextcloud user * move sock file to /var/run * start notify-push after the watcher * ² * remove warning * cron can sometimes fail when the database is not fully initialized, retries the cron job several times and catch catch the error on failure * oupsie * Apply suggestions from code review Co-authored-by: eric_G <[email protected]> --------- Co-authored-by: Éric Gaspar <[email protected]> Co-authored-by: yunohost-bot <[email protected]> * Remove ~duplicate pre-upgrade message (#723) * Fix notify_push after reboot/restart the service, create the folder /var/run/nextcloud via systemd * Update manifest.toml * Auto-update READMEs * Update backup * 29.0.7 * Auto-update READMEs * Add comment about the cron check for high perf backend * Add extended description of the notify push option --------- Co-authored-by: yunohost-bot <[email protected]> Co-authored-by: OniriCorpe <[email protected]> Co-authored-by: lyyn <[email protected]> Co-authored-by: tituspijean <[email protected]> Co-authored-by: Alexandre Aubin <[email protected]> Co-authored-by: YunoHost Bot <[email protected]> Co-authored-by: Alexandre Aubin <[email protected]> Co-authored-by: Kayou <[email protected]> Co-authored-by: Björn Richter <[email protected]> Co-authored-by: ^x3ro <[email protected]>

* Update manifest.toml * Auto-update READMEs * add pre upgrade warning for NC 29 * update to PHP8.3 * Auto-update READMEs * Update manifest.toml * Auto-update READMEs * Fix space splitting in phpflags on install (#690) * Auto-update READMEs * Update upgrade * Update manifest.toml * Auto-update READMEs * Fix phpflags (#691) * Fix upgrade: php version is 8.3 starting from 29.x ? (#692) * Update manifest.toml * Auto-update READMEs * Update tests.toml * [autopatch] Do not delete logs on app removal (#697) * [autopatch] Do not delete logs on app removal (#698) Co-authored-by: Yunohost-Bot <> * 29.0.3 * Auto-update READMEs * Update remove * Indent * Fix again upgrade ending with Nextcloud being in PHP 8.2 ? * Auto-update READMEs * Update nginx.conf * Update manifest.toml * Auto-update READMEs * Rework DESCRIPTION.md (#707) * Update DESCRIPTION_fr.md * Auto-update READMEs * Update DESCRIPTION.md * Auto-update READMEs * Update DESCRIPTION_fr.md * Auto-update READMEs --------- Co-authored-by: yunohost-bot <[email protected]> * bump all old versions * oupsie * Auto-update READMEs * system_addressbook_exposed is a boolean * Auto-update READMEs * migrate system_addressbook_exposed to boolean, fix upgrade test * another fix for system_addressbook_exposed, update the dav conf accordingly * zblerg, do not modify system_addressbook_exposed config value in the upgrade script * add redis-server as deps * find files before chown them * chown the root folder too * fix find condition * find ... chmod is not faster, at least avoid to chown -R the data_dir in the upgrade script * add a button in the config panel to run chown/chmod on data_dir * we can avoid this chmod too i guess? * only nextcloud is allowed to read the config file * zblerg, the config file doesn't exist before install * wait until nginx has actually remove the nextcloud conf during upgrade before checking the url_handled * create a function for that * fix change-url dav detection * only if domain has changed... * Update scripts/_common.sh * moar sleep * oups * minor typos * Update backup * minor typos * Fix removing ACL permissions on uninstall According to `man setfacl`, for the `--remove` option "[o]nly ACL entries without the perms field are accepted as parameters". * Fix: Add missing `file` argument to `setfacl` * Fix: Use absolute path for removing ACL permissions * Update manifest.toml * Auto-update READMEs * Add notify push option (#417) * add notify_push option * self-test notify_push * fix notify_app * new permission hpb, some fixes * fix the restore script * fix restore² * fix upgrade * fix socket path * Update doc/DISCLAIMER_fr.md * split nginx conf * use official helpers with modified args * Auto-update READMEs * update nginx conf, add new services * add tests * add arch var * tests: enable_notify_push is false by default * fix upgrade * final_path -> install_dir * fix socket nginx path * add notify_push nginx conf before, so the reload in ynh_add_nginx_config load it * fully functional version * readd a removed fix * run cron task after notify push setup * Auto-update READMEs * remove systemd files * add notify push in config panel * add cron again because to make notify push happy * fix indent * enable/disable the notify push path * fix path unit * exec only for nextcloud user * move sock file to /var/run * start notify-push after the watcher * ² * remove warning * cron can sometimes fail when the database is not fully initialized, retries the cron job several times and catch catch the error on failure * oupsie * Apply suggestions from code review Co-authored-by: eric_G <[email protected]> --------- Co-authored-by: Éric Gaspar <[email protected]> Co-authored-by: yunohost-bot <[email protected]> * Remove ~duplicate pre-upgrade message (#723) * Fix notify_push after reboot/restart the service, create the folder /var/run/nextcloud via systemd * Update manifest.toml * Auto-update READMEs * Update backup * 29.0.7 * Auto-update READMEs * Add comment about the cron check for high perf backend * Add extended description of the notify push option * Fixed backup (#732) * Update backup * Update manifest.toml * Auto-update READMEs * Update backup * cleaning --------- Co-authored-by: yunohost-bot <[email protected]> Co-authored-by: OniriCorpe <[email protected]> Co-authored-by: lyyn <[email protected]> Co-authored-by: tituspijean <[email protected]> Co-authored-by: Alexandre Aubin <[email protected]> Co-authored-by: YunoHost Bot <[email protected]> Co-authored-by: Alexandre Aubin <[email protected]> Co-authored-by: Kayou <[email protected]> Co-authored-by: Björn Richter <[email protected]> Co-authored-by: ^x3ro <[email protected]> Co-authored-by: orhtej2 <[email protected]>

* Update manifest.toml * Auto-update READMEs * add pre upgrade warning for NC 29 * update to PHP8.3 * Auto-update READMEs * Update manifest.toml * Auto-update READMEs * Fix space splitting in phpflags on install (#690) * Auto-update READMEs * Update upgrade * Update manifest.toml * Auto-update READMEs * Fix phpflags (#691) * Fix upgrade: php version is 8.3 starting from 29.x ? (#692) * Update manifest.toml * Auto-update READMEs * Update tests.toml * [autopatch] Do not delete logs on app removal (#697) * [autopatch] Do not delete logs on app removal (#698) Co-authored-by: Yunohost-Bot <> * 29.0.3 * Auto-update READMEs * Update remove * Indent * Fix again upgrade ending with Nextcloud being in PHP 8.2 ? * Auto-update READMEs * Update nginx.conf * Update manifest.toml * Auto-update READMEs * Rework DESCRIPTION.md (#707) * Update DESCRIPTION_fr.md * Auto-update READMEs * Update DESCRIPTION.md * Auto-update READMEs * Update DESCRIPTION_fr.md * Auto-update READMEs --------- Co-authored-by: yunohost-bot <[email protected]> * bump all old versions * oupsie * Auto-update READMEs * system_addressbook_exposed is a boolean * Auto-update READMEs * migrate system_addressbook_exposed to boolean, fix upgrade test * another fix for system_addressbook_exposed, update the dav conf accordingly * zblerg, do not modify system_addressbook_exposed config value in the upgrade script * add redis-server as deps * find files before chown them * chown the root folder too * fix find condition * find ... chmod is not faster, at least avoid to chown -R the data_dir in the upgrade script * add a button in the config panel to run chown/chmod on data_dir * we can avoid this chmod too i guess? * only nextcloud is allowed to read the config file * zblerg, the config file doesn't exist before install * wait until nginx has actually remove the nextcloud conf during upgrade before checking the url_handled * create a function for that * fix change-url dav detection * only if domain has changed... * Update scripts/_common.sh * moar sleep * oups * minor typos * Update backup * minor typos * Fix removing ACL permissions on uninstall According to `man setfacl`, for the `--remove` option "[o]nly ACL entries without the perms field are accepted as parameters". * Fix: Add missing `file` argument to `setfacl` * Fix: Use absolute path for removing ACL permissions * Update manifest.toml * Auto-update READMEs * Add notify push option (#417) * add notify_push option * self-test notify_push * fix notify_app * new permission hpb, some fixes * fix the restore script * fix restore² * fix upgrade * fix socket path * Update doc/DISCLAIMER_fr.md * split nginx conf * use official helpers with modified args * Auto-update READMEs * update nginx conf, add new services * add tests * add arch var * tests: enable_notify_push is false by default * fix upgrade * final_path -> install_dir * fix socket nginx path * add notify_push nginx conf before, so the reload in ynh_add_nginx_config load it * fully functional version * readd a removed fix * run cron task after notify push setup * Auto-update READMEs * remove systemd files * add notify push in config panel * add cron again because to make notify push happy * fix indent * enable/disable the notify push path * fix path unit * exec only for nextcloud user * move sock file to /var/run * start notify-push after the watcher * ² * remove warning * cron can sometimes fail when the database is not fully initialized, retries the cron job several times and catch catch the error on failure * oupsie * Apply suggestions from code review Co-authored-by: eric_G <[email protected]> --------- Co-authored-by: Éric Gaspar <[email protected]> Co-authored-by: yunohost-bot <[email protected]> * Remove ~duplicate pre-upgrade message (#723) * Fix notify_push after reboot/restart the service, create the folder /var/run/nextcloud via systemd * Update manifest.toml * Auto-update READMEs * Update backup * 29.0.7 * Auto-update READMEs * 30.0.0 * Auto-update READMEs * Update manifest.toml * Auto-update READMEs * Update tests.toml * Update manifest.toml * Update screenshot.png * cleaning * cleaning * Update tests.toml * Update manifest.toml * Auto-update READMEs * Auto-update READMEs * Update manifest.toml --------- Co-authored-by: yunohost-bot <[email protected]> Co-authored-by: OniriCorpe <[email protected]> Co-authored-by: lyyn <[email protected]> Co-authored-by: tituspijean <[email protected]> Co-authored-by: Alexandre Aubin <[email protected]> Co-authored-by: YunoHost Bot <[email protected]> Co-authored-by: Alexandre Aubin <[email protected]> Co-authored-by: Kayou <[email protected]> Co-authored-by: Björn Richter <[email protected]> Co-authored-by: ^x3ro <[email protected]>

* Update manifest.toml * Auto-update READMEs * add pre upgrade warning for NC 29 * update to PHP8.3 * Auto-update READMEs * Update manifest.toml * Auto-update READMEs * Fix space splitting in phpflags on install (#690) * Auto-update READMEs * Update upgrade * Update manifest.toml * Auto-update READMEs * Fix phpflags (#691) * Fix upgrade: php version is 8.3 starting from 29.x ? (#692) * Update manifest.toml * Auto-update READMEs * Update tests.toml * [autopatch] Do not delete logs on app removal (#697) * [autopatch] Do not delete logs on app removal (#698) Co-authored-by: Yunohost-Bot <> * 29.0.3 * Auto-update READMEs * Update remove * Indent * Fix again upgrade ending with Nextcloud being in PHP 8.2 ? * Auto-update READMEs * Update nginx.conf * Update manifest.toml * Auto-update READMEs * Rework DESCRIPTION.md (#707) * Update DESCRIPTION_fr.md * Auto-update READMEs * Update DESCRIPTION.md * Auto-update READMEs * Update DESCRIPTION_fr.md * Auto-update READMEs --------- Co-authored-by: yunohost-bot <[email protected]> * bump all old versions * oupsie * Auto-update READMEs * system_addressbook_exposed is a boolean * Auto-update READMEs * migrate system_addressbook_exposed to boolean, fix upgrade test * another fix for system_addressbook_exposed, update the dav conf accordingly * zblerg, do not modify system_addressbook_exposed config value in the upgrade script * add redis-server as deps * find files before chown them * chown the root folder too * fix find condition * find ... chmod is not faster, at least avoid to chown -R the data_dir in the upgrade script * add a button in the config panel to run chown/chmod on data_dir * we can avoid this chmod too i guess? * only nextcloud is allowed to read the config file * zblerg, the config file doesn't exist before install * wait until nginx has actually remove the nextcloud conf during upgrade before checking the url_handled * create a function for that * fix change-url dav detection * only if domain has changed... * Update scripts/_common.sh * moar sleep * oups * minor typos * Update backup * minor typos * Fix removing ACL permissions on uninstall According to `man setfacl`, for the `--remove` option "[o]nly ACL entries without the perms field are accepted as parameters". * Fix: Add missing `file` argument to `setfacl` * Fix: Use absolute path for removing ACL permissions * Update manifest.toml * Auto-update READMEs * Add notify push option (#417) * add notify_push option * self-test notify_push * fix notify_app * new permission hpb, some fixes * fix the restore script * fix restore² * fix upgrade * fix socket path * Update doc/DISCLAIMER_fr.md * split nginx conf * use official helpers with modified args * Auto-update READMEs * update nginx conf, add new services * add tests * add arch var * tests: enable_notify_push is false by default * fix upgrade * final_path -> install_dir * fix socket nginx path * add notify_push nginx conf before, so the reload in ynh_add_nginx_config load it * fully functional version * readd a removed fix * run cron task after notify push setup * Auto-update READMEs * remove systemd files * add notify push in config panel * add cron again because to make notify push happy * fix indent * enable/disable the notify push path * fix path unit * exec only for nextcloud user * move sock file to /var/run * start notify-push after the watcher * ² * remove warning * cron can sometimes fail when the database is not fully initialized, retries the cron job several times and catch catch the error on failure * oupsie * Apply suggestions from code review Co-authored-by: eric_G <[email protected]> --------- Co-authored-by: Éric Gaspar <[email protected]> Co-authored-by: yunohost-bot <[email protected]> * Remove ~duplicate pre-upgrade message (#723) * Fix notify_push after reboot/restart the service, create the folder /var/run/nextcloud via systemd * Update manifest.toml * Auto-update READMEs * Update backup * 29.0.7 * Auto-update READMEs * 30.0.0 * Auto-update READMEs * Update manifest.toml * Auto-update READMEs * Update tests.toml * Update manifest.toml * Update screenshot.png * cleaning * cleaning * Update tests.toml * helpers * cleaning * Update config * Update config * fix * Create .gitignore * Update install * Update upgrade * Update install * Update _common.sh * cleaning * Update backup * Update upgrade * Auto-update READMEs * Update config * Update config_panel.toml * Update tests.toml * Update backup * Update scripts/config Co-authored-by: Alexandre Aubin <[email protected]> * Update scripts/change_url Co-authored-by: Alexandre Aubin <[email protected]> * Fix patch handling, no more trick required because patches are now well identified as being meant for the 'main' (=latest) source * Update scripts/restore Co-authored-by: Alexandre Aubin <[email protected]> * Update upgrade * Remove the need for custom mysql helper (requires yunohost 12.0. ... 8 ?) * fix * Update install * Update upgrade * Update upgrade * Update upgrade * Update manifest.toml * Update manifest.toml: bump again yunohost requirement to 12.0.8.2 * Update upgrade * Update manifest.toml: sources for 30.0.3 disappeared again so we have to fucking revert to 30.0.2 zzzzzz * Auto-update READMEs * Update 00-add-logout_url-conf.patch * Update 01-disable-CSPv3-nonce_and_allow-YNH-fonts.patch * Update 01-disable-CSPv3-nonce_and_allow-YNH-fonts.patch * Delete sources/patches/.gitignore * Update upgrade * Update scripts/upgrade: gotta use -E for grep to recognize the + quantifier * Update manifest.toml --------- Co-authored-by: yunohost-bot <[email protected]> Co-authored-by: OniriCorpe <[email protected]> Co-authored-by: lyyn <[email protected]> Co-authored-by: tituspijean <[email protected]> Co-authored-by: Alexandre Aubin <[email protected]> Co-authored-by: YunoHost Bot <[email protected]> Co-authored-by: Alexandre Aubin <[email protected]> Co-authored-by: Kayou <[email protected]> Co-authored-by: Björn Richter <[email protected]> Co-authored-by: ^x3ro <[email protected]>

ericgaspar requested changes Jun 8, 2021

View reviewed changes

manifest.json Outdated Show resolved Hide resolved

kay0u marked this pull request as ready for review June 9, 2021 16:33

kay0u commented Jun 9, 2021

View reviewed changes

conf/systemd.service Outdated Show resolved Hide resolved

kay0u commented Jun 9, 2021

View reviewed changes

scripts/install Outdated Show resolved Hide resolved

ericgaspar deleted the branch testing July 3, 2022 09:32

ericgaspar closed this Jul 3, 2022

ericgaspar reopened this Jul 3, 2022

ericgaspar previously requested changes Feb 13, 2023

View reviewed changes

doc/DISCLAIMER_fr.md Outdated Show resolved Hide resolved

ericgaspar deleted the branch testing August 12, 2023 13:42

ericgaspar closed this Aug 12, 2023

ericgaspar reopened this Aug 12, 2023

add notify_push option

274ad45

kay0u added 7 commits August 26, 2024 16:13

enable/disable the notify push path

f6829db

fix path unit

81afc1b

exec only for nextcloud user

ca5228c

move sock file to /var/run

bf4e212

start notify-push after the watcher

046d7b2

²

4e2e3fa

remove warning

ca8c2d6

YunoHost-Apps deleted a comment from yunohost-bot Aug 26, 2024

kay0u added 3 commits August 27, 2024 09:43

cron can sometimes fail when the database is not fully initialized, r…

454e9f5

…etries the cron job several times and catch catch the error on failure

oupsie

cbed1ef

Merge pull request #720 from YunoHost-Apps/trying-to-fix-the-cron-task

4c8bceb

cron can sometimes fail when the database is not fully initialized, r…

ericgaspar reviewed Aug 27, 2024

View reviewed changes

doc/ADMIN_fr.md Outdated Show resolved Hide resolved

doc/ADMIN.md Outdated Show resolved Hide resolved

Apply suggestions from code review

4854f50

Co-authored-by: eric_G <[email protected]>

ericgaspar approved these changes Aug 27, 2024

View reviewed changes

ericgaspar merged commit d7d2403 into testing Aug 27, 2024

ericgaspar deleted the add-notify_push-option branch August 27, 2024 12:52

ericgaspar mentioned this pull request Aug 27, 2024

Testing #721

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add notify push option #417

Add notify push option #417

kay0u commented Jun 8, 2021 •

edited

Loading

kay0u commented Jun 9, 2021

kay0u commented Jun 9, 2021

yunohost-bot commented Jun 9, 2021

kay0u commented Jun 10, 2021

yunohost-bot commented Jun 10, 2021

kay0u commented Jun 10, 2021

yunohost-bot commented Jun 10, 2021

Thovi98 commented Nov 2, 2021

kay0u commented Nov 5, 2021

Thovi98 commented Nov 9, 2021

JocelynDelalande commented Mar 3, 2022

ericgaspar commented Jul 3, 2022

yunohost-bot commented Jul 3, 2022

ericgaspar commented Nov 11, 2022

yunohost-bot commented Nov 11, 2022

ericgaspar commented Feb 13, 2023

yunohost-bot commented Feb 13, 2023

tomdereub commented Jul 24, 2023

kay0u commented Aug 26, 2024

yunohost-bot commented Aug 26, 2024

yunohost-bot commented Aug 26, 2024

kay0u commented Aug 27, 2024

Add notify push option #417

Add notify push option #417

Conversation

kay0u commented Jun 8, 2021 • edited Loading

Solution

PR Status

Automatic tests

kay0u commented Jun 9, 2021

kay0u commented Jun 9, 2021

yunohost-bot commented Jun 9, 2021

kay0u commented Jun 10, 2021

yunohost-bot commented Jun 10, 2021

kay0u commented Jun 10, 2021

yunohost-bot commented Jun 10, 2021

Thovi98 commented Nov 2, 2021

kay0u commented Nov 5, 2021

Thovi98 commented Nov 9, 2021

JocelynDelalande commented Mar 3, 2022

ericgaspar commented Jul 3, 2022

yunohost-bot commented Jul 3, 2022

ericgaspar commented Nov 11, 2022

yunohost-bot commented Nov 11, 2022

ericgaspar commented Feb 13, 2023

yunohost-bot commented Feb 13, 2023

tomdereub commented Jul 24, 2023

kay0u commented Aug 26, 2024

yunohost-bot commented Aug 26, 2024

yunohost-bot commented Aug 26, 2024

kay0u commented Aug 27, 2024

kay0u commented Jun 8, 2021 •

edited

Loading