Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Github workflow to build YNH package supporting custom path #75

Open
wants to merge 3 commits into
base: testing
Choose a base branch
from

Conversation

oleole39
Copy link

@oleole39 oleole39 commented Nov 9, 2024

Problem

Custom path install not supported with current cinny_ynh version

Solution

Use github workflow to build a specific package supporting YNH custom path install.

  1. Merge this PR on testing
  2. A first release has to be created using workflow triggered on every push to testing branch. It will create a draft release at https://github.com/YunoHost-Apps/cinny_ynh/releases where sample versioning/text should be corrected and then published.
  3. add path & SHA sum corresponding that that first release in the manifest
  4. merge PR to master
  5. you may want to disable manually the workflow triggered on every push to testing branch, to enable it only when needed. The main workflow is triggered everytime it detects a PR from yunohost-bot mentioning an upgrade available (based on manifest autoupdate's strategy).
  6. For each new upgrade PR by yunohost-bot, BEFORE merging the latter, the draft release automatically created by the workflow will have to be published manually, and source ynh_build (URL and SHA sum) has to be replaced manually in the manifest.

PR Status

  • Code finished and ready to be reviewed/tested
  • The code base of the PR comes mostly from app it-tools_ynh where it seems to work properly:
    • GH workflow when push on testing works fine
    • install script working and app overall navigation was tested manually
    • CI passed
    • GH workflow when pull request is yet to be tested (waiting for an upgrade from upstream...)
    • CI says it's fine, but I wonder whether path should be modified via scripting when changing URL, or restoring on a different path - to be checked
  • Code for this app has been manually tested

Notes:

  • Yunorunner on this PR will fail as long as there is no published release in this repo / linked to in the manifest.
  • The build script added with this PR can be run locally and even generate draft Github release if a Github personal token is supplied

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant