fix: skip external URLs in withBase (vuejs#328)

YunYouJun · Aug 30, 2021 · e740fc2 · e740fc2
1 parent 9f52bf1
commit e740fc2
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/src/client/app/utils.ts b/src/client/app/utils.ts
@@ -1,5 +1,5 @@
 import { siteDataRef } from './data'
-import { inBrowser } from '../shared'
+import { inBrowser, EXTERNAL_URL_RE } from '../shared'
 
 export { inBrowser }
 
@@ -11,7 +11,9 @@ export function joinPath(base: string, path: string): string {
 }
 
 export function withBase(path: string) {
-  return joinPath(siteDataRef.value.base, path)
+  return EXTERNAL_URL_RE.test(path)
+    ? path
+    : joinPath(siteDataRef.value.base, path)
 }
 
 /**

diff --git a/src/shared/shared.ts b/src/shared/shared.ts
@@ -8,6 +8,8 @@ export type {
   Header
 } from '../../types/shared'
 
+export const EXTERNAL_URL_RE = /^https?:/i
+
 export const inBrowser = typeof window !== 'undefined'
 
 function findMatchRoot(route: string, roots: string[]) {