-
-
Notifications
You must be signed in to change notification settings - Fork 982
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configuration option to disable photos within the library #107
Conversation
* Added new parameter in the configuration to support disable photos in library * Updated refreshMediaRequest to apply new filter
@portellaa Thank you for the kind words 😃 🍾 ! Have a good day sir! |
Hi guys 👋 Do you have updates on this PR? Cheers |
@portellaa Telepathy, I was about to write you |
Niiice 😀 I will fix rebase the PR now, it seems that there is some conflicts. |
Hey @portellaa don't bother I'm merging locally at the moment :) |
Just merged but I think we still have a little issue, when changing albums, we need to hid albums that contain no photos I guess. I had a crash :) Have to go right now but I'll have time tomorrow to look at it. |
@s4cha i will look into it also. thanks and sorry for introduce the bug. |
@portellaa No problem, this happens :) I'm taking a look at the moment. |
@portellaa Ok I've got the fix :) Will push soon !!! |
1cf71c1 👍 That was easier than I thought :) |
awesome sir 🙇 nicely done 🎉 |
Hello 👋
First of all, nice lib, one of the best pickers i have tried and the one i choose for my current project.
So i have a requirement in my project, which is only support videos in the library viewer and so i decided to do the changes and submit a pull request 😅 (and 🙏)
So what did i change: 👇
👉 Added new parameter in the configuration to support disable photos in
library
👉 Updated refreshMediaRequest to apply new filter
And it's basically that.
I left a comment and i would like to hear your thoughts around that, when the user doesn't selects photos neither videos, what should the library show.
Thanks 🍻 🙏