Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configuration option to disable photos within the library #107

Merged
merged 2 commits into from
May 16, 2018

Conversation

portellaa
Copy link

Hello 👋

First of all, nice lib, one of the best pickers i have tried and the one i choose for my current project.

So i have a requirement in my project, which is only support videos in the library viewer and so i decided to do the changes and submit a pull request 😅 (and 🙏)

So what did i change: 👇

👉 Added new parameter in the configuration to support disable photos in
library
👉 Updated refreshMediaRequest to apply new filter

And it's basically that.

I left a comment and i would like to hear your thoughts around that, when the user doesn't selects photos neither videos, what should the library show.

Thanks 🍻 🙏

Luís Portela Afonso added 2 commits May 8, 2018 17:07
* Added new parameter in the configuration to support disable photos in
library

* Updated refreshMediaRequest to apply new filter
@s4cha
Copy link
Member

s4cha commented May 8, 2018

@portellaa Thank you for the kind words 😃 🍾 !
This looks like a very nice addition and clean implementation to me 👌 !
I will have time to review and test this tomorrow, stay tuned :)
@NikKovIos Any thoughts ?

Have a good day sir!

@portellaa
Copy link
Author

Hi guys 👋

Do you have updates on this PR?

Cheers

@s4cha
Copy link
Member

s4cha commented May 16, 2018

@portellaa Telepathy, I was about to write you
Sorry we took quite a long time polishing the multiple selection PR that just got merged.
I can finally take a look :)

@portellaa
Copy link
Author

Niiice 😀

I will fix rebase the PR now, it seems that there is some conflicts.
We have released our App today in the AppStore, with this library.
You have one more App using your library 🎉 😄

@s4cha
Copy link
Member

s4cha commented May 16, 2018

Hey @portellaa don't bother I'm merging locally at the moment :)
That's really awesome to know! I think we gonna have a section in the readme to showcase the apps using it 👍

@s4cha s4cha merged commit 65e3974 into Yummypets:master May 16, 2018
@s4cha
Copy link
Member

s4cha commented May 16, 2018

Just merged but I think we still have a little issue, when changing albums, we need to hid albums that contain no photos I guess. I had a crash :) Have to go right now but I'll have time tomorrow to look at it.
Thank you SO much man!!!

@portellaa
Copy link
Author

@s4cha i will look into it also. thanks and sorry for introduce the bug.

@s4cha
Copy link
Member

s4cha commented May 17, 2018

@portellaa No problem, this happens :) I'm taking a look at the moment.

@s4cha
Copy link
Member

s4cha commented May 17, 2018

@portellaa Ok I've got the fix :) Will push soon !!!

@s4cha
Copy link
Member

s4cha commented May 17, 2018

1cf71c1 👍 That was easier than I thought :)

@portellaa
Copy link
Author

awesome sir 🙇 nicely done 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants