fix(config:vue): allow void elements in "vue/html-self-closing" (#24)

See prettier/eslint-config-prettier#85
Yproximite · Nov 7, 2020 · dfff99b · dfff99b
1 parent 5be7062
commit dfff99b
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 18 deletions.
diff --git a/__tests__/fixtures/component.vue b/__tests__/fixtures/component.vue
@@ -8,6 +8,7 @@
       </div>
     </transition>
 
+    <input type="text" name="my-input" />
     <slot />
 
     <MyComponent>

diff --git a/__tests__/functional.test.ts b/__tests__/functional.test.ts
@@ -87,33 +87,27 @@ describe('Functional', function () {
           "message": "Component name \\"transition\\" is not PascalCase.",
           "ruleId": "vue/component-name-in-template-casing",
         },
-        Object {
-          "column": 9,
-          "line": 7,
-          "message": "Disallow self-closing on HTML void elements (<img/>).",
-          "ruleId": "vue/html-self-closing",
-        },
         Object {
           "column": 29,
-          "line": 14,
+          "line": 15,
           "message": "Delete \`·\`",
           "ruleId": "prettier/prettier",
         },
         Object {
           "column": 5,
-          "line": 19,
+          "line": 20,
           "message": "Component name \\"v-component\\" is not PascalCase.",
           "ruleId": "vue/component-name-in-template-casing",
         },
         Object {
           "column": 5,
-          "line": 31,
+          "line": 32,
           "message": "Unexpected console statement.",
           "ruleId": "no-console",
         },
         Object {
           "column": 17,
-          "line": 31,
+          "line": 32,
           "message": "Replace \`\\"Hello·world!\\"\` with \`'Hello·world!'\`",
           "ruleId": "prettier/prettier",
         },
@@ -147,12 +141,6 @@ describe('Functional', function () {
           "message": "Replace \`⏎········my·image:·<img·src=\\"https://example.com/image.png\\"·/>⏎······\` with \`my·image:·<img·src=\\"https://example.com/image.png\\"·/>\`",
           "ruleId": "prettier/prettier",
         },
-        Object {
-          "column": 19,
-          "line": 6,
-          "message": "Disallow self-closing on HTML void elements (<img/>).",
-          "ruleId": "vue/html-self-closing",
-        },
         Object {
           "column": 28,
           "line": 13,

diff --git a/src/config-generator.test.ts b/src/config-generator.test.ts
@@ -61,7 +61,7 @@ describe('Configuration generator', function () {
             registeredComponentsOnly: false,
           },
         ],
-        'vue/html-self-closing': ['error'],
+        'vue/html-self-closing': ['error', { html: { void: 'always' } }],
         'vue/no-duplicate-attr-inheritance': ['error'],
         'vue/no-empty-component-block': ['error'],
         'vue/no-template-target-blank': ['error'],

diff --git a/src/config-generator.ts b/src/config-generator.ts
@@ -96,7 +96,7 @@ function configureVue(previousConfig: ESLintConfig, options: Options): ESLintCon
         registeredComponentsOnly: false,
       },
     ],
-    'vue/html-self-closing': ['error'],
+    'vue/html-self-closing': ['error', { html: { void: 'always' } }],
     'vue/no-duplicate-attr-inheritance': ['error'],
     'vue/no-empty-component-block': ['error'],
     'vue/no-template-target-blank': ['error'],