Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to TypeScript 3.4 #272

Merged
merged 1 commit into from
Apr 4, 2019

Conversation

marionebl
Copy link
Contributor

Update to TypeScript 3.4. This includes the following the changes.

  • Update specified TypeScript dependency to 3.4
  • Update yarn.lock to format > 1.9, See yarnpkg/yarn#6440
  • Simplify a condition in getTypeDefinition that was not entered after upgrading to 3.4, which causes some tests regarding aliases to fail. I cross checked with 3.0 and the proposed changes work with those older versions, too.
Please: - [x] Do not include the compiled `.js`, `.js.map`, or `.d.ts` in your pull request as it makes it harder to merge your changes. - [x] Make your pull request atomic, fixing one issue at a time unless there are many relevant issues that cannot be decoupled. - [] ~~Provide a test case & update the documentation in the `Readme.md`~~ Not applicable

@domoritz
Copy link
Collaborator

domoritz commented Apr 4, 2019

Thank you. Looks great.

@domoritz domoritz merged commit 6eda5bc into YousefED:master Apr 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants