Add centos support

[jonathanmorley]

No description provided.

[majormoses]

would it not be better to do some detection rather than having to manage a list of versions?

[jonathanmorley]

Yes, now detecting versions

[majormoses]

I meant something more along the lines of some helper functions detect the presence of systemd, upstart, and fall back to sysvinit:

def systemd?
  IO.read('/proc/1/comm').chomp == 'systemd'
end

def upstart?
  File.executable?('/sbin/initctl')
end

def determine_init_subsytem
  if systemd?
    'systemd'
  elsif upstart?
    'upstart'
  else
    'sysv'
  end
end

We can still choose to overwrite it if we want (such as in a docker container where you would never run systemd) but we can try doing some sane default detection.

[majormoses]

@jonathanmorley is there a reason they cant be a single resource called something like service which uses some helper library to determine the appropriate subsystem? This feels kind of wrong to have a custom resource for debian as well as each init subsystem...just my 2 cents...

[majormoses]

@jonathanmorley with this we are expecting the user in their wrapper to know if they are systemd or init right? I think we should have some example in the readme. Also this is a breaking change should this be a major CB bump?

[jonathanmorley]

The systemd and init resources are very similar, and I dont think there is a need to have a single resource.

Through dynamic resolution the two resources behave as one, and picks automatically based on the init process. There is no need for the user to know their init system (see tests).

The only breaking change should be the dropping of the 'default' recipe.

[majormoses]

sorry I misread, its not a breaking change. With how close they are I do feel like the effort would be minimal to make a single resource. But we can let the maintainer give their thoughts on this. I have yet to pull down and test this out.