dfflibmap: Add a -dont_use flag to ignore cells #4219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is an alternative to setting the dont_use property in lib. This brings dfflibmap in parity with the abc pass for dont_use. Signed-off-by: Austin Rovinski <[email protected]>
|
I (hopefully) fixed compilation on Windows and also added a simple test case. |
|
@nakengelhardt This one would be useful to us, and @rovinski is a known collaborator of the OpenROAD project. |
Depending on the WIN32 compilation mode, PathMatchSpec may expect a LPCSTR or LPCWSTR argument. char* is only convertable to LPCSTR, so use that implementation Signed-off-by: Austin Rovinski <[email protected]>
|
Windows build issue resolved - all tests pass now. |
povik
reviewed
Feb 20, 2024
| @@ -115,7 +122,15 @@ static bool parse_pin(LibertyAst *cell, LibertyAst *attr, std::string &pin_name, | |||
| return false; | |||
| } | |||
|
|
|||
| static void find_cell(LibertyAst *ast, IdString cell_type, bool clkpol, bool has_reset, bool rstpol, bool rstval) | |||
| static int glob_match(const char *pattern, const char *string) { | |||
There was a problem hiding this comment.
Please use patmatch from kernel/yosys.cc for this, if possible
There was a problem hiding this comment.
I didn't see that, thanks. Opened #4223.
This was referenced Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternative to setting the
dont_useproperty in lib. This bringsdfflibmapin parity with the abc pass for-dont_use.This feature is extremely useful in the case where Liberty files are not easily modifiable, such as when they are stored on a read-only network drive.
This is my first PR here, so I am very open to feedback!