Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make CURRENT_GIT_VERSION logic robust in release tarballs #227

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

DanielG
Copy link

@DanielG DanielG commented Jun 24, 2023

This automatically embeds git version information into tarballs built with git-archive. This even works for tarballs downloaded from Github.

Essentially the same trick as in YosysHQ/yosys#3138 with one complication: git-tag information is not available to the export-subst (see gitattributes(5)) format string so we use the commit date instead.

We retain the current git-describe based string for git checkouts but it might be advisable to align this to be the HEAD commit date plus commit hash too.

This automatically embeds git version information into tarballs built with
git-archive. This even works for tarballs downloaded from Github.

Essentially the same trick as in YosysHQ/yosys#3138
with one complication: git-tag information is not available to the
export-subst (see gitattributes(5)) format string so we use the commit date
instead.

We retain the current git-describe based string for git checkouts but it
might be advisable to align this to be the HEAD commit date plus commit
hash too.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant