graph conn #61
Merged
graph conn #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #61 +/- ##
==========================================
+ Coverage 90.00% 90.25% +0.25%
==========================================
Files 17 18 +1
Lines 570 585 +15
==========================================
+ Hits 513 528 +15
Misses 57 57
Flags with carried forward coverage won't be shown. Click here to find out more.
|
justjhong
reviewed
Dec 9, 2022
| Parameters | ||
| ---------- | ||
| X | ||
| Array of shape (n_cells, n_cells) with non-zero values |
There was a problem hiding this comment.
do you want to assert the k nearest neighbors?
There was a problem hiding this comment.
left as a todo as we have to make global utils for this
| tab = pd.value_counts(comps) | ||
| clust_res.append(tab.max() / sum(tab)) | ||
|
|
||
| return np.mean(clust_res) |
There was a problem hiding this comment.
the cell types are weighted equally regardless of the proportions?
adamgayoso
commented
Dec 9, 2022
justjhong
approved these changes
Dec 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11