Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kmeans memory fix #45

Merged
merged 2 commits into from
Oct 25, 2022
Merged

Kmeans memory fix #45

merged 2 commits into from
Oct 25, 2022

Conversation

martinkim0
Copy link
Member

No description provided.

@martinkim0 martinkim0 requested a review from adamgayoso October 25, 2022 17:05
@codecov
Copy link

codecov bot commented Oct 25, 2022

Codecov Report

Merging #45 (f2cc988) into main (4e8bdcf) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #45   +/-   ##
=======================================
  Coverage   92.90%   92.90%           
=======================================
  Files          16       16           
  Lines         564      564           
=======================================
  Hits          524      524           
  Misses         40       40           
Flag Coverage Δ
unittests 92.90% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/scib_metrics/utils/_kmeans.py 93.40% <100.00%> (ø)

@adamgayoso
Copy link
Member

@martinkim0 can you add a new note to the changelog for 0.0.7?

@martinkim0 martinkim0 merged commit ec1ff51 into main Oct 25, 2022
@martinkim0 martinkim0 deleted the kmeans-fix branch October 25, 2022 17:29
@adamgayoso adamgayoso mentioned this pull request Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants