Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change behavior of None default metrics and allow results/plotting to work with bio/batch separately. #181

Merged
merged 9 commits into from
Nov 4, 2024

Conversation

adamgayoso
Copy link
Member

@adamgayoso adamgayoso commented Nov 3, 2024

Closes #157

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link

codecov bot commented Nov 3, 2024

Codecov Report

Attention: Patch coverage is 76.47059% with 4 lines in your changes missing coverage. Please review.

Project coverage is 90.78%. Comparing base (a2575da) to head (88a747f).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/scib_metrics/benchmark/_core.py 76.47% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #181      +/-   ##
==========================================
- Coverage   91.08%   90.78%   -0.30%     
==========================================
  Files          26       26              
  Lines         965      977      +12     
==========================================
+ Hits          879      887       +8     
- Misses         86       90       +4     
Files with missing lines Coverage Δ
src/scib_metrics/benchmark/_core.py 96.36% <76.47%> (-2.33%) ⬇️

@adamgayoso adamgayoso merged commit e31aa1c into main Nov 4, 2024
9 checks passed
@adamgayoso adamgayoso deleted the benchmark_refactor branch November 4, 2024 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bm.plot_results_table() fails when all batch correction metrics are set to False
1 participant