Leaf Subsampler Speedup #228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #228 +/- ##
==========================================
+ Coverage 79.49% 79.53% +0.04%
==========================================
Files 89 89
Lines 8050 8064 +14
==========================================
+ Hits 6399 6414 +15
+ Misses 1651 1650 -1
☔ View full report in Codecov by Sentry. |
|
Also, speeds up the |
mattjones315
approved these changes
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the
UniformLeafSubsampler~50X faster for large trees by improvingremove_leaves_and_prune_lineages. Specifically, instead of checking internal nodes many times, we are now using a heap to check internal nodes in order from the bottom of the tree to the top. Additionally, the__networknow is modified directly which avoids repeated calls to__check_network_initialized().