Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Blood Glucose, Body Fat, Body Temperaure, and Basal Metabolic Rate sensors #74

Merged
merged 28 commits into from
Jul 24, 2023
Merged

Add Blood Glucose, Body Fat, Body Temperaure, and Basal Metabolic Rate sensors #74

merged 28 commits into from
Jul 24, 2023

Conversation

lunarok
Copy link
Contributor

@lunarok lunarok commented Jul 15, 2023

No description provided.

@lunarok lunarok mentioned this pull request Jul 15, 2023
Closed
3 tasks
@YorkshireIoT YorkshireIoT added the breaking change Changes that require integration reconfiguration label Jul 17, 2023
YorkshireIoT
YorkshireIoT requested changes Jul 17, 2023
View reviewed changes
Copy link
Owner

@YorkshireIoT YorkshireIoT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR 👍

Generally looks all good to me except the minor renaming things I've pointed out

custom_components/google_fit/api.py Outdated Show resolved Hide resolved
custom_components/google_fit/api.py Outdated Show resolved Hide resolved
custom_components/google_fit/const.py Outdated Show resolved Hide resolved
custom_components/google_fit/const.py Outdated Show resolved Hide resolved
@lunarok
Copy link
Contributor Author

lunarok commented Jul 18, 2023

Yes, look better, actually didn't see that Github has forwarded the commits done after the PR, was expecting to push first only glucose and test the others first
But tests are done and it works on my side, but names are better in proposition yes

YorkshireIoT
YorkshireIoT requested changes Jul 19, 2023
View reviewed changes
custom_components/google_fit/api.py Outdated Show resolved Hide resolved
custom_components/google_fit/api.py Outdated Show resolved Hide resolved
custom_components/google_fit/api_types.py Outdated Show resolved Hide resolved
custom_components/google_fit/api_types.py Outdated Show resolved Hide resolved
custom_components/google_fit/const.py Outdated Show resolved Hide resolved
custom_components/google_fit/const.py Outdated Show resolved Hide resolved
custom_components/google_fit/const.py Show resolved Hide resolved
@YorkshireIoT YorkshireIoT changed the title Add Glucose sensor Add Bloody Glucose, Body Fat, Body Temperaure, and Basal Metabolic Rate sensors Jul 19, 2023
@YorkshireIoT YorkshireIoT changed the title Add Bloody Glucose, Body Fat, Body Temperaure, and Basal Metabolic Rate sensors Add Blood Glucose, Body Fat, Body Temperaure, and Basal Metabolic Rate sensors Jul 19, 2023
lunarok and others added 8 commits July 19, 2023 23:48
@lunarok @YorkshireIoT
Update custom_components/google_fit/api.py
2f19b28 
Co-authored-by: YorkshireIoT <[email protected]>
@lunarok @YorkshireIoT
Update custom_components/google_fit/api.py
bb2e789 
Co-authored-by: YorkshireIoT <[email protected]>
@lunarok @YorkshireIoT
Update custom_components/google_fit/api_types.py
b7e6dbd 
Co-authored-by: YorkshireIoT <[email protected]>
@lunarok @YorkshireIoT
Update custom_components/google_fit/api_types.py
c263bde 
Co-authored-by: YorkshireIoT <[email protected]>
@lunarok @YorkshireIoT
Update custom_components/google_fit/const.py
c0914b1 
Co-authored-by: YorkshireIoT <[email protected]>
@lunarok @YorkshireIoT
Update custom_components/google_fit/const.py
7527af9 
Co-authored-by: YorkshireIoT <[email protected]>
@lunarok @YorkshireIoT
Update custom_components/google_fit/const.py
936b7f3 
Co-authored-by: YorkshireIoT <[email protected]>
@lunarok @YorkshireIoT
Update custom_components/google_fit/const.py
ec080a9 
Co-authored-by: YorkshireIoT <[email protected]>
YorkshireIoT
YorkshireIoT requested changes Jul 22, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
custom_components/google_fit/const.py Show resolved Hide resolved
@YorkshireIoT YorkshireIoT merged commit 85c03c0 into YorkshireIoT:main Jul 24, 2023
@YorkshireIoT
Copy link
Owner

Thank you for all your work @lunarok 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YorkshireIoT YorkshireIoT YorkshireIoT requested changes

Assignees
No one assigned
Labels
breaking change Changes that require integration reconfiguration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lunarok @YorkshireIoT