-
-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adds remove functionality to LRUCache and LRUMap #154
Conversation
Hello @trivikr. Thanks for your PR. The reason why I advocated for an This said, I am bothered, as you were, by the redundancy of the code because it makes all of this more difficult to maintain. But the fact is I am not sold on using runtime abstraction to solve the issue at the cost of performance and maybe some macro/preprocessor tool can help? |
Created new PR to add delete functionality in About reusing code, we can continue discussing on relevant issues #159 and #160 |
Fixes: #143
This PR adds
remove
functionality to LRUCache and LRUMap.Changes done: