Add metrics exporter for Prometheus #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…be19835d4036db1c975ff17455fe7e7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compatible with https://github.com/Yolean/kubernetes-monitoring and probably most other Kubernetes + Prometheus setups. Should be useful with the Grafana dashboard from https://github.com/rama-nallamilli/kafka-prometheus-monitoring/blob/master/dashboards/Kafka.json.
Unlike https://github.com/rama-nallamilli/kafka-prometheus-monitoring/blob/master/prometheus-jmx-exporter/confd/templates/kafka.yml.tmpl I saw no reason to make the JMX_PORT configurable, as there's no need to export it outside the pod (a benefit with k8s compared to docker-compose). To tweak configuration I suggest a ConfigMap with the metrics setup.