cp configmap elements over to config volume as configmap vol is RO #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I ran into the same problem as well. This fix seems to be working as intended on our cluster. |
|
Fixes #162. I will give it a test before I merge, in a day or two. |
|
@rubbish I've pushed two commits, one to apply the fix for ephemeral zoo and one to correct an inconsistency observed by in @clintfred in #162 (comment). I've verified these in a test cluster. If you're ok with them I will merge. |
|
LGTM too. thanks @solsson |
lamdor
commented
Mar 24, 2018
README.md
Outdated
| @@ -28,6 +28,7 @@ If you begin to rely on this kafka setup we recommend you fork, for example to e | |||
|
|
|||
| | tag | k8s ≥ | highlights | | |||
| | ----- | ------ | ---------- | | |||
| | master | 1.9.4 | Required for read-only ConfigMaps, k8s 1.9.4+ | | |||
There was a problem hiding this comment.
Quick note that the readonly configmap volume fix was backported and released as 1.8.9 and 1.7.14 too so each of those need master as well.
There was a problem hiding this comment.
Thanks again @rubbish. I have apparently not been paying enough attention. I'll merge this now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into an issue when deploying this onto our Tectonic kubernetes cluster. It turns out that the ConfigMap volumes are mounted read-only. I'm unsure if this is standard kubernetes behavior, but minikube does not do the same thing; it allows modification of the configmap files. Glancing at kubernetes code, it appears it should be mounted read-only.
So to fix this, I made a new emptyDir volume for where the config should go and then make the init containers copy the configmap files before they modify them.