Skip to content

Commit

Permalink
mdio-tools: fix mdio-netlink kernel module reproducibility
Browse files Browse the repository at this point in the history
mdio-netlink source make reference to ${S}/.. which breaks
-fdebug-prefix-map and results in the full TMPDIR path being present in
the -dbg package and, also, change a related CRC in the main package.

This changes ${S} to enclose the whole SRC_URI repo and adapt relative paths to
build (MODULES_MODULE_SYMVERS_LOCATION)

This make mdio-netlink reproducible and fixes this warning:
WARNING: mdio-netlink-1.3.1-r0 do_package_qa: QA Issue: File /lib/modules/6.6.29-yocto-standard/updates/.debug/mdio-netlink.ko in package mdio-netlink-dbg contains reference to TMPDIR [buildpaths]

Signed-off-by: Yoann Congal <[email protected]>
Reviewed-by: Alexandre Truong <[email protected]>
Signed-off-by: Khem Raj <[email protected]>
  • Loading branch information
ycongal-smile authored and kraj committed May 21, 2024
1 parent 3584b79 commit d161de0
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 4 deletions.
2 changes: 0 additions & 2 deletions meta-networking/conf/include/non-repro-meta-networking.inc
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ KNOWN_NON_REPRO_META_NETWORKING = " \
htpdate-doc \
keepalived \
keepalived-dbg \
kernel-module-mdio-netlink-6.6.17-yocto-standard \
libbearssl-staticdev \
libfko3 \
libfko-client \
Expand All @@ -25,7 +24,6 @@ KNOWN_NON_REPRO_META_NETWORKING = " \
libowfat-staticdev \
libruli-staticdev \
libsamba-util0 \
mdio-netlink-dbg \
mosquitto \
mosquitto-dbg \
ncftp \
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,12 @@ require mdio-tools.inc
DEPENDS += "virtual/kernel libmnl"
# This module requires Linux 5.6 higher

S = "${WORKDIR}/git/kernel"
S = "${WORKDIR}/git"

inherit module

EXTRA_OEMAKE = "KDIR=${STAGING_KERNEL_DIR}"
EXTRA_OEMAKE = "-C kernel/ KDIR=${STAGING_KERNEL_DIR}"
MODULES_MODULE_SYMVERS_LOCATION="kernel"
MODULES_INSTALL_TARGET = "install"

RPROVIDES:${PN} += "kernel-module-mdio-netlink"

0 comments on commit d161de0

Please sign in to comment.